Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout regression bug in AdvCore with FV3+ADV #94

Open
wants to merge 2 commits into
base: geos/develop
Choose a base branch
from

Conversation

sdrabenh
Copy link

This is 0-diff in the stock configuration. However, these changes fix the layout regression issue when the following lines are enabled in AGCM.rc:

DYCORE: FV3+ADV
AdvCore_Advection: 1

@sdrabenh sdrabenh added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 18, 2023
@wmputman
Copy link

There are more updates needed. I will make a new commit today

@mathomp4
Copy link
Member

@wmputman This PR is throwing a failure in the CI testing in GEOS-ESM/FVdycoreCubed_GridComp#262 (which exercises it). It looks like when you build with FV_PRECISION=R8 an interface is wrong:

/root/project/GEOSfvdycore/src/Components/@FVdycoreCubed_GridComp/@fvdycore/model/fv_grid_utils.F90(3184): error #6633: The type of the actual argument differs from the type of the dummy argument.   [PEM]
        p4 = g_sum(domain, pem, is, ie, js, je, ng, area, 1)
---------------------------^

I think the issue is that pem is declared as:

  real, allocatable:: pem(:,:)

and when you compile as R8, real is now REAL64 and g_sum is now a "fixed" REAL32 routine.

@mathomp4
Copy link
Member

@wmputman @sdrabenh I worked with @tclune and I think we have a fix for the FV_PRECISION=R8 case. I'm compiling now and then I'll test GEOS to make sure I didn't break anything.

But one of you might either have to test the FV3+ADV case or teach me how to run that!

@mathomp4 mathomp4 added the Contingent - DNA These changes are contingent on other PRs label Dec 19, 2023
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, 0 diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA These changes are contingent on other PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants