Fix uninitialized variables for GCC 13 #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: View changes with whitespace off:
https://github.com/GEOS-ESM/GFDL_atmos_cubed_sphere/pull/96/files?w=1
as my editor cleans up trailing spaces.
This PR fixes an issue found by @tclune and @atrayano in their AIST work and in my work with GCC 13.
The issue GCC 13 found was that because these variables that control FMS diagnostic use in FV3 were not being set code like this:
was being triggered. I guess Intel must set uninit integers to zero, but GCC 13 does not. So, when memory space is shifted enough, things like
idiag%id_te
could be randomly greater than zero. This then triggers the if-block andsend_data
will only work ifdiag_manager_init
is called. This is not done in FV3 and you end up with:I will test this along with GEOS-ESM/FVdycoreCubed_GridComp#280 with both Intel and GCC to make sure it is zero diff.