Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/acollow/233_aodlongnames #250

Closed
wants to merge 1 commit into from

Conversation

acollow
Copy link

@acollow acollow commented Aug 18, 2023

state spec RC files for GOCART2G, CA, DU, NI, SU, and SS are updated to make AOD long names more intuitive for users, addressing issue #233

@acollow acollow added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 18, 2023
@acollow acollow requested a review from a team as a code owner August 18, 2023 11:41
@mathomp4
Copy link
Member

@acollow Where did you start from? Your changes look to me (esp. in the CHANGELOG) like you didn't start from develop but from one of the @sdrabenh tags that v11.0 and v11.1 use (which is a sort of zero-diff extension of v2.1.2 (until the GCM can get to GEOS-ESM/GEOSgcm#529).

Did you want this on the 2.1.2 "branch"? If so, I can help with that, and then work to issue a sdr_v2.1.2.8 with this change.

Note that much of what you did here is on develop, like the "*" bits. You can see this in a temporary merge branch I made of your branch and develop:

develop...allie-plus-develop

@acollow
Copy link
Author

acollow commented Aug 18, 2023

@mathomp4, yeah, I realized that this morning but then had to leave for various things before I finished updating it starting with develop. I am not sure why the compilers are failing though...

@acollow acollow closed this Aug 18, 2023
@acollow acollow deleted the feature/acollow/233_aodlongnames branch August 18, 2023 17:08
@mathomp4
Copy link
Member

The CI isn't happy because of updates in GEOSgcm. We need #243 in to make the CI work again (with GEOSgcm tests at least)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants