Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all *ExtData.rc from GOCART/ #269

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

jrjoshi1
Copy link

Regarding issue #267
Removed all the *ExtData.rc files from the GOCART/ directory (in develop), those from the parallel 'AChem' not changed.

@jrjoshi1 jrjoshi1 requested a review from a team as a code owner March 11, 2024 17:51
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@mathomp4
Copy link
Member

@jrjoshi1 You have now encountered both the GMAO Label Enforcer and Changelog Enforcer.

For the first, you need to add a label of either "0 diff", "0 diff trivial", "0 diff structural", or "Non 0-diff". Most use the first or last. The middle two are for things like "added to readme" or "moved a file".

The second is the Changelog Enforcer which make sure you have added an entry to CHANGELOG.md. We follow Keep a Changelog format (ish), so you make entries under things like "Changed" or "Removed" etc. You can see in the file various examples.

@jrjoshi1
Copy link
Author

@mathomp4 Thank you. Will work on that. Perhaps delete this branch, work on new, and then issue PR with a label and a changelog entry.

@mathomp4
Copy link
Member

@mathomp4 Thank you. Will work on that. Perhaps delete this branch, work on new, and then issue PR with a label and a changelog entry.

@jrjoshi1 No need to do that. You can just edit the CHANGELOG on your branch and push (or even edit here on the web).

And then the label is just over on the right of this webpage:

Screenshot 2024-03-12 at 9 44 50 AM

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@jrjoshi1 jrjoshi1 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 12, 2024
vbuchard
vbuchard previously approved these changes Aug 12, 2024
@vbuchard vbuchard merged commit e62ba85 into develop Aug 12, 2024
4 of 11 checks passed
@vbuchard vbuchard deleted the feature/jrjoshi1/#267/RemoveExtData.rc branch August 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants