Feature/acollow/#277-useGCsuffixforCAlongnames #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbon long names
acollow
added
the
0 diff
6 tasks
mathomp4
reviewed
Jun 21, 2024
Co-authored-by: Matt Thompson <[email protected]>
|
Note: The CI will go boom until the MAPL tag is made and then is in the |
elakkraoui
previously approved these changes
Jun 21, 2024
mathomp4
approved these changes
Jun 21, 2024
|
I re-approved only because my CI fix dismissed the review by @elakkraoui. But my change was in the CircleCI config so nothing substantive came in. |
elakkraoui
approved these changes
Jun 21, 2024
sdrabenh
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMakeLists.txt was edit by adding:
mapl_acg (${this} CA2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
GET_POINTERS DECLARE_POINTERS
LONG_NAME_PREFIX "GCsuffix")
This, alongside a MAPL update that has been merged into R21C, will allow for the GCsuffix (BC, OC, and BR) to be used instead of CA.* in the long names for carbon diagnostics.