Skip to content

Commit

Permalink
Merge pull request #2930 from GEOS-ESM/feature/mathomp4/add-refactor-…
Browse files Browse the repository at this point in the history
…to-template

Add Refactor to PR Template
  • Loading branch information
mathomp4 authored Jul 30, 2024
2 parents 98273b3 + f11add4 commit d444793
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ parameters:

# Anchors to prevent forgetting to update a version
os_version: &os_version ubuntu20
baselibs_version: &baselibs_version v7.23.0
baselibs_version: &baselibs_version v7.25.0
bcs_version: &bcs_version v11.5.0
tag_build_arg_name: &tag_build_arg_name maplversion

Expand Down Expand Up @@ -179,9 +179,9 @@ workflows:
baselibs_version: *baselibs_version
container_name: mapl
mpi_name: intelmpi
mpi_version: 2021.6.0
mpi_version: "2021.13"
compiler_name: intel
compiler_version: 2022.1.0
compiler_version: "2024.2"
image_name: geos-env
tag_build_arg_name: *tag_build_arg_name
- ci/publish_docker:
Expand Down
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Trivial change (affects only documentation or cleanup)
- [ ] Refactor (no functional changes, no api changes)

## Checklist
- [ ] Tested this change with a run of GEOSgcm
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
name: Build and Test MAPL GNU
runs-on: ubuntu-latest
container:
image: gmao/ubuntu20-geos-env-mkl:v7.24.0-openmpi_5.0.2-gcc_13.2.0
image: gmao/ubuntu20-geos-env-mkl:v7.25.0-openmpi_5.0.2-gcc_13.2.0
# Per https://github.com/actions/virtual-environments/issues/1445#issuecomment-713861495
# It seems like we might not need secrets on GitHub Actions which is good for forked
# pull requests
Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
name: Build and Test MAPL Intel
runs-on: ubuntu-latest
container:
image: gmao/ubuntu20-geos-env:v7.24.0-intelmpi_2021.6.0-intel_2022.1.0
image: gmao/ubuntu20-geos-env:v7.25.0-intelmpi_2021.13-intel_2024.2
# Per https://github.com/actions/virtual-environments/issues/1445#issuecomment-713861495
# It seems like we might not need secrets on GitHub Actions which is good for forked
# pull requests
Expand Down

0 comments on commit d444793

Please sign in to comment.