Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to Fix LDAS PR #568 #1601

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Hotfix to Fix LDAS PR #568 #1601

merged 5 commits into from
Jul 15, 2022

Conversation

mathomp4
Copy link
Member

Description

In testing MAPL 2.23.0 with the LDAS it was found that it ran into issues with binary History output. History kept saying that the binary output file existed before writing. @bena-nasa could only really see this in the GCM when more than one file was written at the same time step, but the LDAS could do it with one.

So, for now we only do the "file exists" check with netCDF4 output. A reading of GETFILE makes me think it should do something similar for binary...but not sure.

Related Issue

GEOS-ESM/GEOSldas#568

Motivation and Context

Let's the LDAS use MAPL 2.23

How Has This Been Tested?

This has been tested by @biljanaorescanin with the LDAS and it fixes their issue. We will test with the GEOSgcm before merging.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jul 15, 2022
@mathomp4 mathomp4 self-assigned this Jul 15, 2022
@mathomp4 mathomp4 added the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jul 15, 2022
@mathomp4 mathomp4 marked this pull request as ready for review July 15, 2022 11:50
@mathomp4 mathomp4 requested review from a team as code owners July 15, 2022 11:50
@mathomp4
Copy link
Member Author

I'm going to block this until it can be tested with GEOSgcm. Should be a trivially zero-diff fix for the GCM (we don't do binary History) but better safe than sorry.

@mathomp4
Copy link
Member Author

Sigh. Stupid GitHub Actions. I might as well fix it in main too.

@bena-nasa bena-nasa removed the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jul 15, 2022
@bena-nasa bena-nasa merged commit e47fcb1 into main Jul 15, 2022
@bena-nasa bena-nasa deleted the hotfix/bmauer/fixes-ldas-pr-#568 branch July 15, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants