Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In testing MAPL 2.23.0 with the LDAS it was found that it ran into issues with binary History output. History kept saying that the binary output file existed before writing. @bena-nasa could only really see this in the GCM when more than one file was written at the same time step, but the LDAS could do it with one.
So, for now we only do the "file exists" check with netCDF4 output. A reading of
GETFILE
makes me think it should do something similar for binary...but not sure.Related Issue
GEOS-ESM/GEOSldas#568
Motivation and Context
Let's the LDAS use MAPL 2.23
How Has This Been Tested?
This has been tested by @biljanaorescanin with the LDAS and it fixes their issue. We will test with the GEOSgcm before merging.
Types of changes
Checklist: