Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check tableEnd efficiently #3178

Merged
merged 3 commits into from
Nov 14, 2024
Merged

check tableEnd efficiently #3178

merged 3 commits into from
Nov 14, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

The "::" will not be returned so it is not necessary to check it every time

Related Issue

@weiyuan-jiang weiyuan-jiang added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Nov 13, 2024
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner November 13, 2024 20:10
@mathomp4 mathomp4 merged commit ad0a569 into develop Nov 14, 2024
35 of 37 checks passed
@mathomp4 mathomp4 deleted the feature/wjiang/tableEnd branch November 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bena-nasa bena-nasa bena-nasa approved these changes

@tclune tclune tclune approved these changes

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiyuan-jiang @mathomp4 @tclune @bena-nasa