Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bank count validation #136

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Add bank count validation #136

merged 2 commits into from
Dec 3, 2024

Conversation

ronakseth96
Copy link
Collaborator

  • Added validation to ensure the bank-count does not exceed the available banks.
  • Added info, that the API URL is already pre-configured for local mode.

Example o/p:

$ ./test-load.sh --mode local --bank-count 15
WARNING: You have selected more banks (15) than available (10).
Please reduce the --bank-count value to 10 or fewer for performing load test.

@ronakseth96 ronakseth96 requested review from 2byrds and aydarng December 3, 2024 15:15
Copy link
Collaborator

@aydarng aydarng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2byrds
Copy link
Collaborator

2byrds commented Dec 3, 2024

@ronakseth96 is this a temporary solution until we produce the 600 bank images?

@ronakseth96
Copy link
Collaborator Author

@2byrds Yes, this is a temporary solution. Currently, we only have data for 10 banks, and we are gradually verifying and updating more. Until we have all 600 bank images, this setup will be in place to manage the test.

@ronakseth96 ronakseth96 self-assigned this Dec 3, 2024
@2byrds 2byrds merged commit 8e78372 into main Dec 3, 2024
5 checks passed
Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants