2주차 심화과제 #3
Open
2주차 심화과제 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RinRinPARK
reviewed
Apr 27, 2023
Comment on lines
+51
to
+57
| if (postId < postList.size()) { | ||
| Post updatePost = new Post( | ||
| post.getWriter(), | ||
| post.getTitle(), | ||
| post.getContent(), | ||
| postList.get(postId).getLike() | ||
| ); |
There was a problem hiding this comment.
if문 조건에서 아직 DB 구현이 되지 않아서 postId < postList.size()일 때만 수정이 가능하게 코드를 작성해주신걸까요?!
해당 로직에선 postId를 다른 postId로 잘못 입력해도 수정이 가능할 것 같아서요!
There was a problem hiding this comment.
아마 if문으로 postId가 postList의 사이즈보다 작아야 해당 포스트가 존재해서 예외처리 해 주신 것 같아요!!
There was a problem hiding this comment.
맞습니다! list 크기를 초과하는 postId가 들어오면 존재하지 않는 게시물이기 때문에 if문을 써줬어요!
Comment on lines
+66
to
+68
| if (postId < postList.size()) { | ||
| postList.remove(postId); | ||
| return Optional.of(postId); |
There was a problem hiding this comment.
여기도 위와 마찬가지로 이렇게 if문을 작성해주신 이유가 궁금합니다!!
jelliijoa
reviewed
Apr 27, 2023
Comment on lines
+51
to
+57
| if (postId < postList.size()) { | ||
| Post updatePost = new Post( | ||
| post.getWriter(), | ||
| post.getTitle(), | ||
| post.getContent(), | ||
| postList.get(postId).getLike() | ||
| ); |
There was a problem hiding this comment.
아마 if문으로 postId가 postList의 사이즈보다 작아야 해당 포스트가 존재해서 예외처리 해 주신 것 같아요!!
| postList.set(postId, updatePost); | ||
| return Optional.of(postList.get(postId).toString()); | ||
| } | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Optional.of와 Optional.empty 제가 처음 보는 메서드인데 뭔가 예외처리를 해줄 수 있는 애들 같아서 기능 찾아보고 저도 나중에 예외처리 할 때 사용해보겠습니다ㅎㅎ 예외처리 하는 방법 하나 배워갑니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 과제 구현 명세
[심화과제]
결과 화면
😊 이런 점이 새로웠어요 / 어려웠어요