Starting the pull request process for PGA 0003 #108
Conversation
changes from my local instance.
Removed internal style sheet from the prefsServerIntegration/index.html Removed Preview Pane Button Removed css refering to preview button added internal style sheet to the main style sheet commented the style sheet according to changes. Removed Project file from git
…demos/index.html. Inline styles moved to stylesheet from confirmTemplate.html. navButtons.js, navIcons.js, firstDiscoveryEditor.js reverted to original. panels.js removed model listeners for logging, removed empty invokers, removed console log statements.Edits to congradulations.json messages for spanish and french. FriendlyWords functions changed for conmfirm panel in panels.js.
created css class for table settings.
firstDiscoveryPerfsServerInegration.html added css id: open to welcome panel.
… an issue identified during integration testing
…scovery into demo2-integration
speech rate converted to words per minute
Confirmation panel updates
| @@ -2,13 +2,13 @@ | |||
| "bitwise": false, | |||
| "camelcase": false, | |||
| "curly": true, | |||
| "eqeqeq": true, | |||
| "eqeqeq": false, | |||
There was a problem hiding this comment.
These settings should be reverted to our project defaults - in particular the use of the === operator correponds to a JS best practice http://stackoverflow.com/questions/359494/does-it-matter-which-equals-operator-vs-i-use-in-javascript-comparisons#answer-359509
|
Hello Antranig, Do the comments above represent a comprehensive review of all of the files in this pull request? |
|
Hi @mkbrenn - no, they don't. It's typical for code review to be an interactive process - especially when the contribution needs such significant rework, as this pull request does, it is very likely that addressing the first round of review comments will expose further issues that were not evident in the original form of the contribution. |
|
Thanks for the quick feedback @amb26. Are changes or feedback from the PGA team regarding the current comments, blockers to further review by the GPII team? |
|
Yes, we need to get these points addressed first, since they will generate a very large diff, create several new source files, linting changes, etc. |
No description provided.