GPII-1716: Windows font-size #115

stegru · 2017-03-09T13:33:53Z

Font-size support for windows, via the SystemParametersInfo.

The changes here are to allow the fWinIni parameter to be defined in the solutions registry.

…lution registry.

…PI_SETICONTITLELOGFONT

gpii-bot · 2017-03-09T13:48:36Z

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

gpii-bot · 2017-03-10T13:34:41Z

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

stegru · 2017-03-14T09:57:29Z

ok to test

amb26 · 2017-06-21T13:48:56Z

gpii/node_modules/WindowsUtilities/WindowsUtilities.js

+        if (typeof(flags) === "string") {
+            var or = flags.indexOf("&") < 0;
+            op = or ? "or" : "and";
+            flags = flags.split(/ *[&|,]+ */);


Why do we permit comma here as well?

Don't know.

amb26 · 2017-06-21T13:49:15Z

gpii/node_modules/WindowsUtilities/WindowsUtilities.js

+        if (fluid.isArrayable(flags)) {
+            togo = gpii.windows.combineFlags(flags, allFlags, op);
+        } else {
+            fluid.log("windows.resolveFlags was passed an unknown type of flags");


This should be fail

amb26 · 2017-06-21T13:52:14Z

gpii/node_modules/spiSettingsHandler/src/SpiSettingsHandler.js

@@ -206,12 +209,16 @@ gpii.windows.spi.applySettings = function (payload) {
    // Wait for sethc.exe to end before making the SPI call
    gpii.windows.spi.waitForSpi()
        .then(function () {
+            // SPIF_SENDCHANGE broadcasts several messages and has the potential to block, so call it in a child
+            // process.
+            var sendChange = (fWinIni & gpii.windows.API_constants.SpiFlags.SPIF_SENDCHANGE) ===


Seems a bit more brief and equally effective to skip the === check

amb26 · 2017-06-21T13:54:06Z

gpii/node_modules/WindowsUtilities/WindowsUtilities.js

+    var or = op !== "and" && op !== "&";
+
+    var combine = or
+        ? function (left, right) { return left | right; }


The legendary Do IIIIIIT block!

amb26 · 2017-06-21T13:54:45Z

Can we get the CI to pass for this?

gpii-bot · 2017-06-21T15:31:53Z

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

javihernandez · 2017-06-21T15:34:35Z

ok to test

gpii-bot · 2017-06-21T15:55:50Z

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

gpii-bot · 2017-06-23T09:36:16Z

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

# Conflicts: # package.json

gpii-bot · 2017-08-07T14:26:07Z

CI job passed.

# Conflicts: # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # package.json

gpii-bot · 2017-09-08T19:15:07Z

CI job passed: https://ci.gpii.net/job/windows-tests/261/

# Conflicts: # package.json

gpii-bot · 2017-10-10T14:40:13Z

CI job passed: https://ci.gpii.net/job/windows-tests/300/

gpii-bot · 2018-02-17T17:18:28Z

CI job passed: https://ci.gpii.net/job/windows-tests/391/

# Conflicts: # package.json

gpii-bot · 2018-04-05T14:55:39Z

CI job passed: https://ci.gpii.net/job/windows-tests/450/

stegru · 2018-04-13T10:35:07Z

ok to test

gpii-bot · 2018-04-13T10:59:23Z

CI job failed: https://ci.gpii.net/job/windows-tests/460/

# Conflicts: # package.json

gpii-bot · 2018-05-07T19:05:32Z

CI job failed: https://ci.gpii.net/job/windows-tests/483/

gpii-bot · 2018-05-07T19:19:15Z

CI job failed: https://ci.gpii.net/job/windows-tests/484/

stegru · 2018-05-07T19:21:22Z

ok to test

==> default: Mounting shared folders...
    default: /vagrant => /home/jenkins-gpii/workspace/windows-tests
Vagrant can't use the requested machine because it is locked! This
means that another Vagrant process is currently reading or modifying
the machine. Please wait for that Vagrant process to end and try
again. Details about the machine are shown below:

Name: default
Provider: virtualbox
Build step 'Execute shell' marked build as failure
Finished: FAILURE

gpii-bot · 2018-05-07T19:27:35Z

CI job failed: https://ci.gpii.net/job/windows-tests/485/

stegru · 2018-05-07T19:30:13Z

ok to test

�[KProgress: 90%There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["import", "/home/jenkins-gpii/.vagrant.d/boxes/inclusivedesign-VAGRANTSLASH-windows10-eval-x64-Apps/2018.03.20/virtualbox/box.ovf", "--vsys", "0", "--vmname", "windows10-eval-x64-Apps-v20180320_1525721153816_93954", "--vsys", "0", "--unit", "12", "--disk", "/home/jenkins-gpii/VirtualBox VMs/windows10-eval-x64-Apps-v20180320_1525721153816_93954/windows10-eval-x64-Apps-v20180320-disk001.vmdk"]

Stderr: 0%...10%...20%...30%...40%...50%...60%...70%...80%...90%...100%
Interpreting /home/jenkins-gpii/.vagrant.d/boxes/inclusivedesign-VAGRANTSLASH-windows10-eval-x64-Apps/2018.03.20/virtualbox/box.ovf...
OK.
0%...
Progress state: VBOX_E_FILE_ERROR
VBoxManage: error: Appliance import failed
VBoxManage: error: Could not create the imported medium '/home/jenkins-gpii/VirtualBox VMs/windows10-eval-x64-Apps-v20180320_1525721153816_93954/windows10-eval-x64-Apps-v20180320-disk001.vmdk'.
VBoxManage: error: VMDK: could not create new file '/home/jenkins-gpii/VirtualBox VMs/windows10-eval-x64-Apps-v20180320_1525721153816_93954/windows10-eval-x64-Apps-v20180320-disk001.vmdk' (VERR_ALREADY_EXISTS)
VBoxManage: error: Details: code VBOX_E_FILE_ERROR (0x80bb0004), component ApplianceWrap, interface IAppliance
VBoxManage: error: Context: "RTEXITCODE handleImportAppliance(HandlerArg*)" at line 886 of file VBoxManageAppliance.cpp
Build step 'Execute shell' marked build as failure
Finished: FAILURE

gpii-bot · 2018-05-07T20:01:58Z

CI job failed: https://ci.gpii.net/job/windows-tests/486/

# Conflicts: # package.json

gpii-bot · 2018-06-20T15:16:10Z

CI job failed: https://ci.gpii.net/job/windows-tests/545/

stegru · 2018-06-21T15:44:37Z

ok to test

Error occurred during logout: Timed out waiting for the SPI call to complete (see GPII-2001)

gpii-bot · 2018-06-21T16:12:12Z

CI job failed: https://ci.gpii.net/job/windows-tests/549/

stegru · 2018-06-21T19:12:28Z

ok to test

Unrelated (but slightly worrying) failure about narrator.

09:09:08.890:  jq: FAIL: Module "gpii.tests.windows.registeredAT" Test name "Testing real AT" - Message: Narrator must be running
09:09:08.890:  jq: Source:     at pok (\\vboxsvr\vagrant\node_modules\infusion\tests\test-core\jqUnit\js\jqUnit.js:112:15)
    at Object.assertTrue (\\vboxsvr\vagrant\node_modules\infusion\tests\test-core\jqUnit\js\jqUnit.js:145:13)
    at Array.<anonymous> (\\vboxsvr\vagrant\gpii\node_modules\registeredAT\test\testRegisteredAT.js:276:16)
    at Object.that.complete

gpii-bot · 2018-06-21T19:40:07Z

CI job failed: https://ci.gpii.net/job/windows-tests/550/

stegru · 2018-06-21T19:58:57Z

2nd time today GPII-2001 has affected a test. Unable to repro on a local VM.

12:39:01.678:  jq: FAIL: Module "gpii.tests.acceptance.windows.builtIn.config tests" Test name "Testing os_common - magnifier and keyboard both running on startup" - Message: Successful login message returned {"isError":true,"message":"Error occurred during login:
 Timed out waiting for the SPI call to complete (see GPII-2001)"}

ok to test

gpii-bot · 2018-06-21T20:25:17Z

CI job failed: https://ci.gpii.net/job/windows-tests/551/

stegru · 2018-06-22T19:54:58Z

ok to test

gpii-bot · 2018-06-22T20:20:51Z

CI job failed: https://ci.gpii.net/job/windows-tests/552/

A slower poll caused the WM_SETTINGCHANGE(?) broadcast from SPI_SETNONCLIENTMETRICS to delay.

gpii-bot · 2018-06-24T15:49:49Z

CI job failed: https://ci.gpii.net/job/windows-tests/553/

stegru · 2018-06-24T18:16:37Z

ok to test

npm ERR! code EINTEGRITY
npm ERR! sha1-0Ng2s0OqbbiMDez+rnHmJ11BQg4= integrity checksum failed when using sha1: wanted sha1-0Ng2s0OqbbiMDez+rnHmJ11BQg4= but got sha1-Rwfn1jU+Ym4KaswUYEmObrJPYYk=. (8026857 bytes)

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\vagrant\AppData\Roaming\npm-cache\_logs\2018-06-24T15_48_39_592Z-debug.log
Installation process returned error code: 1
At C:\tmp\Provisioning.psm1:44 char:5
+     throw "Installation process returned error code: $($exitCode)"
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Installation pr...d error code: 1:String) [], RuntimeException
    + FullyQualifiedErrorId : Installation process returned error code: 1

Build step 'Execute shell' marked build as failure
Finished: FAILURE

gpii-bot · 2018-06-24T18:43:44Z

CI job passed: https://ci.gpii.net/job/windows-tests/554/

stegru · 2018-06-24T19:21:34Z

ok to test - again, to ensure it wasn't a fluke.

gpii-bot · 2018-06-24T19:48:24Z

CI job passed: https://ci.gpii.net/job/windows-tests/555/

amb26 · 2018-10-04T23:50:16Z

Shall we dust this one off? It looks harmless enough

stegru added 2 commits March 8, 2017 14:06

GPII-1716: Added the ability to set fWinIni SPI parameter from the so…

e741956

…lution registry.

GPII-1716: Added font-size support, via SPI_SETNONCLIENTMETRICS and S…

c82850e

…PI_SETICONTITLELOGFONT

stegru mentioned this pull request Jun 14, 2017

GPII-1716: Windows font-size GPII/universal#506

Open

amb26 reviewed Jun 21, 2017

View reviewed changes

stegru added 2 commits June 21, 2017 15:59

Merge remote-tracking branch 'upstream/master' into GPII-1716

8c005e3

GPII-1716: Updated reference to the working universal branch.

c2f748a

GPII-1716: Minor quality improvements.

c57b1bb

stegru added 2 commits August 2, 2017 12:20

Merge remote-tracking branch 'upstream/master' into GPII-1716

0b14783

# Conflicts: # package.json

Merge remote-tracking branch 'upstream/master' into GPII-1716

908fb2b

# Conflicts: # package.json

Merge remote-tracking branch 'upstream/master' into GPII-1716

c7102a2

# Conflicts: # gpii/node_modules/WindowsUtilities/WindowsUtilities.js # package.json

Merge remote-tracking branch 'upstream/master' into GPII-1716

8c8139e

# Conflicts: # package.json

stegru added 2 commits February 19, 2018 15:36

Merge remote-tracking branch 'upstream/master' into GPII-1716

dcd3ef1

Merge remote-tracking branch 'upstream/master' into GPII-1716

48c1411

# Conflicts: # package.json

Merge remote-tracking branch 'upstream/master' into GPII-1716

85fbec3

# Conflicts: # package.json

GPII-1716: Valid json.

c2b2ac6

Merge remote-tracking branch 'upstream/master' into GPII-1716

7e6c2b4

# Conflicts: # package.json

GPII-1716: Increased message pump rate to avoid timeouts in tests.

a63c6d3

A slower poll caused the WM_SETTINGCHANGE(?) broadcast from SPI_SETNONCLIENTMETRICS to delay.

GPII-1716: Windows font-size #115

Are you sure you want to change the base?

GPII-1716: Windows font-size #115

Conversation

stegru commented Mar 9, 2017

gpii-bot commented Mar 9, 2017

gpii-bot commented Mar 10, 2017

stegru commented Mar 14, 2017

amb26 Jun 21, 2017

Choose a reason for hiding this comment

stegru Jun 23, 2017

Choose a reason for hiding this comment

amb26 Jun 21, 2017

Choose a reason for hiding this comment

stegru Jun 23, 2017

Choose a reason for hiding this comment

amb26 Jun 21, 2017

Choose a reason for hiding this comment

stegru Jun 23, 2017

Choose a reason for hiding this comment

amb26 Jun 21, 2017

Choose a reason for hiding this comment

amb26 commented Jun 21, 2017

gpii-bot commented Jun 21, 2017

javihernandez commented Jun 21, 2017

gpii-bot commented Jun 21, 2017

gpii-bot commented Jun 23, 2017

gpii-bot commented Aug 7, 2017

gpii-bot commented Sep 8, 2017

gpii-bot commented Oct 10, 2017

gpii-bot commented Feb 17, 2018

gpii-bot commented Apr 5, 2018

stegru commented Apr 13, 2018

gpii-bot commented Apr 13, 2018

gpii-bot commented May 7, 2018

gpii-bot commented May 7, 2018

stegru commented May 7, 2018

gpii-bot commented May 7, 2018

stegru commented May 7, 2018

gpii-bot commented May 7, 2018

gpii-bot commented Jun 20, 2018

stegru commented Jun 21, 2018

gpii-bot commented Jun 21, 2018

stegru commented Jun 21, 2018

gpii-bot commented Jun 21, 2018

stegru commented Jun 21, 2018 • edited Loading

gpii-bot commented Jun 21, 2018

stegru commented Jun 22, 2018

gpii-bot commented Jun 22, 2018

gpii-bot commented Jun 24, 2018

stegru commented Jun 24, 2018

gpii-bot commented Jun 24, 2018

stegru commented Jun 24, 2018

gpii-bot commented Jun 24, 2018

amb26 commented Oct 4, 2018

stegru commented Jun 21, 2018 •

edited

Loading