Allow Visitor to use CallInst

[TylerNowicki]

• We have encountered IR where it is necessary to transform a CallInst.
• This requires a CallInst visitor. Although, a CallInst visitor can be
  added to the OpMap, it fails to find the CallInst visitor. Instead it
  gives up when it determines the Call is not an intrinsic or
  llvm-dialect op.
• This change ensures we can find the CallInst visitor.

[tsymalla-AMD]

Thanks!
Can you please extend the IR-level tests as well, so we can see it handles IR with a call and a callbr properly, when there is neither a dialect op nor an intrinsic callback registered?

[Flakebi]

Looks good, some nitpicks inline

[TylerNowicki]

when there is neither a dialect op nor an intrinsic callback registered?

I don't understand this part of your request.

[Flakebi]

If I understand Thomas correctly, he means using a visitor with a CallInst in the example here: https://github.com/GPUOpen-Drivers/llvm-dialects/blob/dev/example/ExampleMain.cpp
I think that makes sense

[TylerNowicki]

If I understand Thomas correctly, he means using a visitor with a CallInst in the example here: https://github.com/GPUOpen-Drivers/llvm-dialects/blob/dev/example/ExampleMain.cpp I think that makes sense

At this point, from what I can see, we don't have any Visitor tests... it would help if there was an existing I can work from, I guess I will have to create that...

Oh, do you mean, add the CallInst to the example?

[Flakebi]

Oh, do you mean, add the CallInst to the example?

Yeah, I meant that. And then print something to out and check it in the test like for the intrinsics.

[TylerNowicki]

Oh, do you mean, add the CallInst to the example?

Yeah, I meant that. And then print something to out and check it in the test like for the intrinsics.

I guess its done... I don't really get it what this is doing.

[Flakebi]

I don't really get it what this is doing.

Ah, you need to add IR and checks here as well (and probably in the other test file): https://github.com/GPUOpen-Drivers/llvm-dialects/blob/dev/test/example/visitor-basic.ll

[tsymalla-AMD]

Yeah. Sebastian understood correctly, please extend the visitor-basic.ll test + ExampleMain so that we can see the visitor visiting a generic CallInst.

[tsymalla-AMD]

I guess its done... I don't really get it what this is doing.

The Example app is invocated during testing. It runs the visitor declared there against a given input LL file and then filechecks against the output there - so it checks if the callbacks are properly invoked.

[TylerNowicki]

Done

[tsymalla]

Looks good to me

[Flakebi]

Nice!