Remove references to the old datagov-deploy repo #1143
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import gunicorn | ||
|
|
||
| gunicorn.SERVER_SOFTWARE = "" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,43 @@ | ||
| describe("Facets", { testIsolation: false }, () => { | ||
| before(() => { | ||
| cy.login(); | ||
| }); | ||
|
|
||
| after(() => { | ||
| cy.delete_organization("org-tags"); | ||
| cy.delete_group("group-facets"); | ||
| cy.logout(); | ||
| }); | ||
|
|
||
| it("Show datagov facet list on dataset page", () => { | ||
| cy.visit("/dataset"); | ||
| cy.get(".filters h2").its("length").should("be.equal", 9); | ||
| cy.get(".filters h2").first().contains("Topics"); | ||
| cy.get(".filters h2").last().contains("Bureaus"); | ||
| }); | ||
|
|
||
| it("Show datagov facet list on organization page", () => { | ||
| cy.visit("/organization"); | ||
| cy.get('a[class="btn btn-primary"]').click(); | ||
| cy.create_organization_ui("org-tags", "tags for org test"); | ||
| cy.visit("/organization/org-tags"); | ||
| cy.get(".module-shallow").its("length").should("be.equal", 11); | ||
| cy.get(".module-shallow").contains("Topics"); | ||
| cy.get(".module-shallow").contains("Harvest Source"); | ||
| cy.get(".module-shallow").last().contains("Bureaus"); | ||
| }); | ||
|
|
||
| it("Show datagov facet list on group page", () => { | ||
| cy.create_group("group-facets"); | ||
| cy.visit("/group/group-facets"); | ||
| cy.get(".filters h2").its("length").should("be.equal", 6); | ||
| cy.get(".filters h2").first().contains("Categories"); | ||
| cy.get(".filters h2").last().contains("Organizations"); | ||
| }); | ||
|
|
||
| // https://github.com/GSA/data.gov/issues/3672 | ||
| it("Can visit organization and group facet link", () => { | ||
| cy.visit("/organization/org-tags?tags=_"); | ||
| cy.visit("/group/group-facets?tags=_"); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| # Locations table | ||
|
|
||
| The locations table [was defined in 2016](https://github.com/GSA/data.gov/search?q=location+table&type=commits). | ||
| This table was deleted from the repo but is still available from old commits: [locations.sql.gz](https://github.com/GSA/data.gov/raw/71936f004be1882a506362670b82c710c64ef796/ansible/roles/software/ec2/ansible/files/locations.sql.gz). | ||
|
There was a problem hiding this comment. This is outdated now that the table is in the docker-entrypoint dir. |
||
|
|
||
| This table could be dd to database with | ||
|
|
||
| ```bash | ||
| ./install-locations-table.sh HOST DB_NAME DB_USER PASS | ||
| ``` | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,18 @@ | ||
| #!/bin/bash | ||
|
|
||
| echo "*** USAGE: $(basename "$0") HOST DB_NAME DB_USER PASS" | ||
|
|
||
| # TODO check path on run | ||
| SQL_FILE=30_locations.sql.gz | ||
|
There was a problem hiding this comment. i'm almost positive the pathing needs to be adjusted |
||
| HOST=$1 | ||
| DB_NAME=$2 | ||
| DB_USER=$3 | ||
| PASS=$4 | ||
|
|
||
| if ! [ -f $SQL_FILE ]; then | ||
| echo "Error: locations.sql file not found, exiting.." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Creating locations table" | ||
| gunzip -c ${SQL_FILE} | PGPASSWORD=${PASS} psql -h "$HOST" -U "$DB_USER" -d "$DB_NAME" -v ON_ERROR_STOP=1 | ||
|
There was a problem hiding this comment. my understanding was putting the .gzipped file in the docker-entrypoint dir executes it automatically when catalog starts up... is that correct? and if so, what does this script here do? |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of updating this link, I think referencing a key piece of DB setup (for dev and prod) at a historical git commit to a file that is no longer being tracked isn't good practice. Can we just add the file in the repo similar to the other files in docker-entrypoint-initdb.d folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to that