update ckanext-datajson for max_resource_count #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuhuXia
had a problem deploying
to
development
GitHub Actions
Failure
|
Verified on catalog-dev. A error is generated for a record with 10k+ resources.
|
jbrown-xentity
approved these changes
Sep 25, 2024
Comment on lines
+144
to
+146
| # Max number of resources to be allowed in a dataset to be harvested | ||
| export CKANEXT__DATAJSON__MAX_RESOURCE_COUNT=1500 | ||
|
|
There was a problem hiding this comment.
Any reason we can't add this to the ckan.ini file? I think this would be the safer place; that way it will be setup by default. I don't see a reason to have a different number between local dev and cloud.gov deployment...
There was a problem hiding this comment.
Tried that before, moved newly created config into ckan.ini but it had no effect.
Just tried again with 50e4055, same result. No effect when set in ckan.ini.
There was a problem hiding this comment.
oops, looks like there is a typo in the last try. trying again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring changes from
Set optional config
ckanext.datajson.max_resource_countto be 1500.