Merge pull request #2012 from GSA/update-prettier-eslint

Update prettier eslint

.vscode/extensions.json

@@ -1,5 +1,3 @@
 {
-	"recommendations": [
-		"rvest.vs-code-prettier-eslint"
-	],
+  "recommendations": ["github.vscode-github-actions", "esbenp.prettier-vscode"]
 }

.vscode/settings.json

@@ -1,10 +1,9 @@
 {
-    "debug.javascript.autoAttachFilter": "onlyWithFlag",
-    "editor.renderWhitespace": "none",
-    "diffEditor.ignoreTrimWhitespace": false,
-    "editor.defaultFormatter": "rvest.vs-code-prettier-eslint",
-    "editor.formatOnType": false,
-    "editor.formatOnSave": true,
-    "editor.formatOnSaveMode": "file",
-    "vs-code-prettier-eslint.prettierLast": true,
+  "debug.javascript.autoAttachFilter": "onlyWithFlag",
+  "editor.renderWhitespace": "none",
+  "diffEditor.ignoreTrimWhitespace": false,
+  "editor.formatOnType": false,
+  "editor.formatOnSave": true,
+  "editor.formatOnSaveMode": "file",
+  "editor.defaultFormatter": "esbenp.prettier-vscode"
 }

benefit-finder/.storybook/main.js

@@ -20,15 +20,16 @@ const config = {
   viteFinal(config) {
     return mergeConfig(config, {
       build: {
-      chunkSizeWarningLimit: '1000',
-      rollupOptions: {
+        chunkSizeWarningLimit: '1000',
+        rollupOptions: {
           output: {
-            manualChunks: (id) => id.includes('src/App/index.jsx') ? 'app-chunk' : false,
+            manualChunks: id =>
+              id.includes('src/App/index.jsx') ? 'app-chunk' : false,
           },
         },
       },
-    });
+    })
   },
-};
+}
 
 export default config

benefit-finder/cypress/e2e/storybook/selected-criteria-eligibility-benefits.cy.js

@@ -97,7 +97,8 @@ describe('Validate correct eligibility benefits display based on selected criter
   })
 
   it('QA scenario 3 Coal Miner EN - Verify correct benefit results for query values that includes Coal Miner in search parameter of URL', () => {
-    const selectedData = BENEFITS_ELIGIBILITY_DATA.scenario_3_coal_miner.en.param
+    const selectedData =
+      BENEFITS_ELIGIBILITY_DATA.scenario_3_coal_miner.en.param
     const enResults = BENEFITS_ELIGIBILITY_DATA.scenario_3_coal_miner.en.results
     const scenario = utils.encodeURIFromObject(selectedData)
 

benefit-finder/cypress/e2e/usagov-public-site/links.cy.js

@@ -58,7 +58,6 @@ describe('Verify correct status code handling', () => {
   // negate validation on our functional code
   Cypress.on('fail', error => {
     if (JSON.stringify(error).includes('httpstat')) {
-
       expect(error).to.not.be.undefined
     } else {
       throw error

benefit-finder/eslint.config.mjs

@@ -5,6 +5,7 @@ import pluginCypress from 'eslint-plugin-cypress/flat'
 import storybook from 'eslint-plugin-storybook'
 import reactPlugin from 'eslint-plugin-react'
 import eslintConfigPrettier from 'eslint-config-prettier'
+import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended'
 import jsxA11y from 'eslint-plugin-jsx-a11y'
 
 // error when starting dev server:
@@ -19,6 +20,7 @@ export default [
   js.configs.recommended,
   json.configs.recommended,
   eslintConfigPrettier,
+  eslintPluginPrettierRecommended,
   ...storybook.configs['flat/recommended'],
   pluginCypress.configs.recommended,
   reactPlugin.configs.flat.all,

benefit-finder/package.json

@@ -69,6 +69,7 @@
     "eslint-plugin-cypress": "^3.6.0",
     "eslint-plugin-json": "^4.0.1",
     "eslint-plugin-jsx-a11y": "^6.10.2",
+    "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-react": "^7.37.2",
     "eslint-plugin-storybook": "^0.10.0",
     "http-server": "^14.1.1",