Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.3.0.beta.1 #1276

Merged
merged 96 commits into from
May 2, 2024
Merged

Release v0.3.0.beta.1 #1276

merged 96 commits into from
May 2, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented May 2, 2024

PR Summary

Completes work for Milestone v0.3.0.beta.1
https://github.com/GSA/px-benefit-finder/milestone/3

Related Github Issue

Module Improvements

Analytics improvements

A11y Improvements

Detailed Testing steps

Module Improvements

Automate draft JSON data file generation #1111

  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Update Time Estimate from 2-5 minutes to 5-10 minutes
  • Save as draft
  • Navigate to Benefit finder app in draft mode: /benefit-finder/death?mode=draft
  • Hard refresh browser
  • Verify "Estimated time 5-10 minutes"

image

Automate JSON data file generation #1060

  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Update Time Estimate from 2-5 minutes to 5-10 minutes
  • Save as published
  • Navigate to Benefit finder app: /benefit-finder/death
  • Hard refresh browser
  • Verify "Estimated time 5-10 minutes"

image

Ensure that agency content can not be deleted if still used #1156

  • Test 1: Can not delete an agency if still used
  • navigate to /admin/content?combine=&type=bears_agency&status=All&langcode=All
  • Go to agency "Social Security Administration (SSA)" edit page
  • click Delete button
  • verify that it lists the benefits that still use the agency Social Security Administration (SSA)
  • verify that no Delete button

image

  • Test 2: Can delete an agency if not used
  • navigate to node/add/bears_agency
  • create an agency
  • edit the newly created agency
  • click Delete button
  • verify that no benefit listed as this agency is not used in any benefit
  • verify that Delete button showing
  • click Delete button
  • verify that the agency is deleted

Ensure that criteria content can not be deleted if still used #1157

  • Test 1: Can not delete a criteria if still used
  • Navigate to /admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • Go to criteria "Applicant date of birth" edit page
  • Click Delete button
  • Verify that it lists the contents that still use the criteria "Applicant date of birth"
  • Verify that no Delete button

image

  • Test 2: Can delete a criteria if not used
  • Navigate to /node/add/bears_criteria
  • Create a criteria
  • Edit the newly created criteria
  • Click Delete button
  • Verify that no content listed as this criteria is not used in any content
  • Verify that Delete button showing
  • click Delete button
  • verify that the criteria is deleted

Generate draft JSON data files when content saved as draft #1141

Add dependency in criteria #1159

  • Navigate to add criteria page: http://localhost/node/add/bears_criteria
  • Go to agency "Social Security Administration (SSA)" edit page
  • confirm "Child dependency option" field is invisible if "has child" field not checked
  • check "has child" field
  • confirm "Child dependency option" field become visible and required

Remove life events field in life event form #1171

  • Navigate to admin/content?combine=&type=bears_benefit&status=All&langcode=All
  • Go to benefit "COVID-19 funeral assistance" edit page
  • Verify that no life events field above life event form field

image

Content under life event link in Benefit Finder landing page / Meta Description #1251

  • navigate to /admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • select life event form Benefit finder: death of a loved one
  • verify that it has short description and page intro field

Analytics improvements

Add H1 in life event page template #1164

and

Address missing H1 on BF LE pages #1028

  • navigate to /benefit-finder/death
  • open web browser inspector
  • In sources select, benefit-finder.min.js
  • set a break point at line 1
  • refresh web page
  • examine H1 from life event page template
  • <h1 class="usa-sr-only" id="skip-to-h1" aria-level="1" hidden="" role="heading">Benefit finder: death of a loved one</h1>
  • ensure content from node is available to DOM but not visible in UI
  • step forward
  • note if JS rehydrates DOM
  • examine H1 from React JS
  • <h1 class="bf-chevron-heading font-family-sans" id="skip-to-h1" aria-level="1" role="heading">Benefit finder: death of a loved one</h1>
  • navigate app steps and ensure only one H1 is present in DOM
Screen.Recording.2024-04-05.at.11.39.51.AM.mov

Include rel with s3 link on template #1180

  • review code, ensure href has new attribute and values

Add virtual page attribute to distinguish between the "pages" of the app and results pages #794

  • navigate form entering values on for required fields
  • inspect the DOM and review the data-testid="bf-result-view" element to ensure it contains the new data-analytics-content* attributes and that they have values

appx rendering should appear as follows

<div class="bf-result-view" data-testid="bf-result-view" data-analytics="bf-result-view" data-analytics-content="bf-eligible-view" data-analytics-content-benefits="<check count>" data-analytics-content-eligible="<check count>" data-analytics-content-not-eligible="<check count>" data-analytics-content-more-info="<check count>" data-analytics-content-criteria-values="<check count>">
  • count the total number of benefits and compare to data-analytics-content-benefits="<check count>"

  • count the total number of eligible items and compare to data-analytics-content-eligible="<check count>"

  • count the total number of not eligible items and compare to data-analytics-content-not-eligible="<check count>"

  • count the total number of more info items and compare to data-analytics-content-more-info="<check count>"

  • count the total number of criteria questions answered and compare to data-analytics-content-criteria-values="<check count>"

  • navigate back through the form and complete values for each of the criteria questions

  • inspect the DOM and review the data-testid="bf-result-view" element to ensure it contains the new data-analytics-content* attributes and that they have updated respectively

Add meta description field in life event #1166

  • Navigate to /admin/content?combine=&type=bears_life_event&status=All&langcode=All
  • Edit life event Benefit finder: death of a loved one
  • Add meta description "Find federal benefits fast. Answer a few questions and in a few minutes get your list of possible benefits across different agencies."
  • Save
  • Navigate to /benefit-finder/death
  • Examine meta description in header

image

a11y improvements

Heading Levels order invalid on Error Stat #1072

  • Navigate to step one of the form
  • Trigger an error by clicking continue
  • Inspect DOM
  • Ensure that heading levels in errors are <h2> while remaining consistent in style to production

Elements must only use supported aria-attributes #1073

  • Navigate to results view
  • Toggle on axeDev tool
  • Run scan
  • Confirm aria error is resolved
  • Inspect elements
  • Confirm that only the <button /> elements in the accordion components have aria-expanded attributes

expected:
Screenshot 2024-04-11 at 10 45 10 AM

Modal Missing H1 #1119

  • Navigate to modal step
  • Inspect
  • Ensure that heading in modal is <h1 />
  • Ensure that styles did not change

Notices list should not include informational alerts #1182

  • Navigate to benefit-finder/death
  • Confirm that notices list renders in the initial view with this info icon

Screenshot 2024-04-12 111310

Info alerts in accordions are hidden to AT #1183

  • Navigate to initial questions
  • Confirm default state of error alert is aria-hidden="true"
  • Trigger error by moving forward without completing required fields
  • Confirm default state updated to aria-hidden="false"

Summary Box vs Accordion Alerts - Accessible Design Options/Design Exploration #1196

  • Navigate to/benefit-finder/death
  • Fill forms and navigate to Results view
  • Note new summary box and content
  • Open accordions to ensure that alerts are no longer present

expected view
screencapture-localhost-6006-iframe-html-2024-04-17-12_39_57

  • In the summary box, click here, to reload the application and revert back to the begining of the form with a null state in form fields
  • Complete form again
  • Share link
  • Paste share link with params in URL bar
  • In the summary box, click here, to reload the application and revert back to the begining of the form with a null state in form fields

a11y test

  • Navigate to Results View
  • Open dev tools, scan with axe
  • Ensure no a11y errors
  • Click open all
  • Open dev tools, scan with axe
  • Ensure no a11y errors

nehemiah-abuga and others added 30 commits April 10, 2024 07:37
…benefit

1227 remove life event in building benefit for JSON data generation
…f github.com:GSA/px-benefit-finder into 1155-github-pipeline-cross-browser-testing
scottqueen-bixal and others added 22 commits April 29, 2024 13:25
…om:GSA/px-benefit-finder into 1205-axe-test-coverage-for-model
…-on-error

1204 test coverage remove skip fail on error
PXBF-1203-e2e-benefits-results-view: add coverage benefits results view
PXBF-1249-suppress-errors-prod-nightly-run: suppress error prod nightly run  scenarios
Notices List updated spacing and alignment
1271 add short description and page intro field in life event
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review May 2, 2024 17:06
@scottqueen-bixal scottqueen-bixal self-assigned this May 2, 2024
@scottqueen-bixal scottqueen-bixal added this to the v0.3.0.beta.1 milestone May 2, 2024
@scottqueen-bixal scottqueen-bixal merged commit 84b56aa into main May 2, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants