-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.3.0.beta.1 #1276
Merged
Merged
Release v0.3.0.beta.1 #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… building benefit
…benefit 1227 remove life event in building benefit for JSON data generation
…f github.com:GSA/px-benefit-finder into 1155-github-pipeline-cross-browser-testing
…om:GSA/px-benefit-finder into 1205-axe-test-coverage-for-model
1205 axe test coverage for model
…-on-error 1204 test coverage remove skip fail on error
… visible to at users
PXBF-1203-e2e-benefits-results-view: add coverage benefits results view
PXBF-1249-suppress-errors-prod-nightly-run: suppress error prod nightly run scenarios
1206 alert aria test coverage
Include vscode setup
Notices List updated spacing and alignment
…tro field in life event
1271 add short description and page intro field in life event
Translation of Summary Component
gchi25
approved these changes
May 2, 2024
nehemiah-abuga
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Completes work for Milestone v0.3.0.beta.1
https://github.com/GSA/px-benefit-finder/milestone/3
Related Github Issue
Module Improvements
Analytics improvements
A11y Improvements
Detailed Testing steps
Module Improvements
Automate draft JSON data file generation #1111
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
Automate JSON data file generation #1060
admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
Ensure that agency content can not be deleted if still used #1156
/admin/content?combine=&type=bears_agency&status=All&langcode=All
node/add/bears_agency
Ensure that criteria content can not be deleted if still used #1157
/admin/content?combine=&type=bears_criteria&status=All&langcode=All
/node/add/bears_criteria
Generate draft JSON data files when content saved as draft #1141
Add dependency in criteria #1159
Remove life events field in life event form #1171
admin/content?combine=&type=bears_benefit&status=All&langcode=All
Content under life event link in Benefit Finder landing page / Meta Description #1251
/admin/content?combine=&type=bears_life_event&status=All&langcode=All
Analytics improvements
Add H1 in life event page template #1164
and
Address missing H1 on BF LE pages #1028
/benefit-finder/death
benefit-finder.min.js
<h1 class="usa-sr-only" id="skip-to-h1" aria-level="1" hidden="" role="heading">Benefit finder: death of a loved one</h1>
<h1 class="bf-chevron-heading font-family-sans" id="skip-to-h1" aria-level="1" role="heading">Benefit finder: death of a loved one</h1>
Screen.Recording.2024-04-05.at.11.39.51.AM.mov
Include rel with s3 link on template #1180
Add virtual page attribute to distinguish between the "pages" of the app and results pages #794
required
fieldsdata-testid="bf-result-view"
element to ensure it contains the newdata-analytics-content*
attributes and that they have valuesappx rendering should appear as follows
count the total number of benefits and compare to
data-analytics-content-benefits="<check count>"
count the total number of eligible items and compare to
data-analytics-content-eligible="<check count>"
count the total number of not eligible items and compare to
data-analytics-content-not-eligible="<check count>"
count the total number of more info items and compare to
data-analytics-content-more-info="<check count>"
count the total number of criteria questions answered and compare to
data-analytics-content-criteria-values="<check count>"
navigate back through the form and complete values for each of the criteria questions
inspect the DOM and review the
data-testid="bf-result-view"
element to ensure it contains the newdata-analytics-content*
attributes and that they have updated respectivelyAdd meta description field in life event #1166
/admin/content?combine=&type=bears_life_event&status=All&langcode=All
/benefit-finder/death
a11y improvements
Heading Levels order invalid on Error Stat #1072
<h2>
while remaining consistent in style to productionElements must only use supported aria-attributes #1073
<button />
elements in the accordion components havearia-expanded
attributesexpected:
Modal Missing H1 #1119
<h1 />
Notices list should not include informational alerts #1182
benefit-finder/death
info
iconInfo alerts in accordions are hidden to AT #1183
Summary Box vs Accordion Alerts - Accessible Design Options/Design Exploration #1196
/benefit-finder/death
expected view
a11y test
open all