-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5.0.beta.1 (sprint 34) #1502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1345 update react test utils
PXBF-ensure-prod-checkout: ensure prod checkout when moved
PXBF-1300-migrate-automated-nightly: remove migrated tests
…k haschild validation
…erage it in testing
…benefit accordion clicks
… when users click to open
…enefit link clicks
… when users click obfuscated links in accordions
1482 structure data layer
…-event 1427 add search title field in life event
1467 benefit link datalayer event
…tents-action 1338 disable auto json file generation in multi-content action
PXBF-PXBF-fix-lint-error: fix lint error
scottqueen-bixal
changed the title
Release v0.5.0.beta.1
Release v0.5.0.beta.1 (sprint 34)
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
https://github.com/GSA/px-benefit-finder/milestone/9?closed=1
Related Github Issue
Application Improvements
NEW FEATURE | Zero Benefits View #1367
Data Analytics Improvements
Structure Data Layer Values #1482
Create a unique data layer value for the modal #1478
bf_page_change fires multiple times on inital page load #1468
Update pageView data layer variable to differentiate between form pages and eligible and ineligible benefits #1477
Create data layer event to track benefit link click #1467
Add data layer value to track benefit accordion open #1466
a11y improvements
a11y | Fonts are not scaling on magnification #1452
Custom Module Improvements
Disable auto json file generation in multi-content action #1338
Detailed Testing steps
Application Improvements
NEW FEATURE | Zero Benefits View #1367
User Testing
/death
NO
( this ensures no benefits view)expected:
Data Testing
See all benefits
expected:
YES
( this ensures eligible benefits view)expected
expected:
Data Analytics Improvements
Structure Data Layer Values #1482
Create a unique data layer value for the modal #1478
bf_page_change fires multiple times on inital page load #1468
Update pageView data layer variable to differentiate between form pages and eligible and ineligible benefits #1477
User Testing
/death
NO
( this ensures no benefits view)you should end up with an array of objects that follow this format
bf_page_change
event isbf-eligible-view-zero-benefits
0
eligible benefits// Initial load from USAGov node page
// Initial load from BF application intro view
"event": "bf_page_change"
event has fired at this location in the array// incrementing steps values as pageView numerics in the dataLayer
"pageView": "bf-form-{step}"
value, in this case we have two steps in the form"event": "bf_modal_open"
, has been pushed by itself, we should not have additional pushes of"event": "bf_page_change"
with the value of"pageView": "bf-form-2"
having been pushed againYES
( this ensures an eligible benefits view)you should end up with additional objects in the array that follow this format
bf_page_change
event isbf-eligible-view
Add data layer value to track benefit accordion open #1466
/death
YES
to all radio fields"event": "bf_benefit_link",
is in the dataLayer array that includes its title valueCreate data layer event to track benefit link click #1467
/death
YES
to all radio fields"event": "bf_benefit_click",
is in the dataLayer array that includes its title valueCLICK the same benefit accordion to close it
console.log(window.dataLayer)
confirm that the benefit you clicked is closed and no new
"event": "bf_benefit_click",
is in the dataLayer arrayCLICK the same benefit accordion to open it, and CLICK a secondary benefit to also open
console.log(window.dataLayer)
confirm that the two (2) benefit you clicked are open and an
"event": "bf_benefit_click",
is in the dataLayer array that includes its title valuea11y improvements
a11y | Fonts are not scaling on magnification #1452
Chrome: Open Settings or Preferences and change the font size to Very large or Very small.
Previous
Example at "Very Large"
Expected
Custom Module Improvements
Disable auto json file generation in multi-content action #1338
To test in local development site or in dev site.
admin/content?combine=&type=bears_criteria&status=All&langcode=All