Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.0.beta.1 (sprint 34) #1502

Merged
merged 99 commits into from
Jun 27, 2024
Merged

Release v0.5.0.beta.1 (sprint 34) #1502

merged 99 commits into from
Jun 27, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jun 26, 2024

PR Summary

https://github.com/GSA/px-benefit-finder/milestone/9?closed=1

Related Github Issue

Application Improvements

NEW FEATURE | Zero Benefits View #1367

Data Analytics Improvements

Structure Data Layer Values #1482
Create a unique data layer value for the modal #1478
bf_page_change fires multiple times on inital page load #1468
Update pageView data layer variable to differentiate between form pages and eligible and ineligible benefits #1477
Create data layer event to track benefit link click #1467
Add data layer value to track benefit accordion open #1466

a11y improvements

a11y | Fonts are not scaling on magnification #1452

Custom Module Improvements

Disable auto json file generation in multi-content action #1338

Detailed Testing steps

Application Improvements

NEW FEATURE | Zero Benefits View #1367

User Testing

  • navigate to /death
  • apply values to all required fields
  • for all radio inputs, select NO ( this ensures no benefits view)

expected:
Screenshot 2024-06-24 at 5 19 32 PM

  • console.log(window.dataLayer)

Data Testing

{
	event: "bf_page_change",
	bfData: {
		pageView: "bf-result-view",
		viewTitle: "You are likely not eligible for benefits",
		viewState: "bf-eligible-view-zero-benefits"
	}
}
  • click See all benefits

expected:

Screenshot 2024-06-24 at 5 48 35 PM
  • console.log(window.dataLayer)
{
	event: "bf_page_change",
	bfData: {
		pageView: "bf-result-view",
		viewTitle: "You are likely not eligible for benefits",
		viewState: "bf-not-eligible-view-zero-benefits"
	}
}
  • return back to start of form, for all radio inputs, select YES ( this ensures eligible benefits view)
  • confirm eligible benefits view

expected
Screenshot 2024-06-24 at 5 56 03 PM

  • console.log(window.dataLayer)
{
	event: "bf_page_change",
	bfData: {
		pageView: "bf-result-view",
		viewTitle: "Your potential benefits",
		viewState: "bf-eligible-view"
	}
}
  • click "See benefits you did not qualify for"

expected:
Screenshot 2024-06-24 at 6 03 46 PM

  • console.log(window.dataLayer)
{
	event: "bf_page_change",
	bfData: {
		pageView: "bf-result-view",
		viewTitle: "Benefits you did not qualify for",
		viewState: "bf-not-eligible-view"
	}
}

Data Analytics Improvements

Structure Data Layer Values #1482
Create a unique data layer value for the modal #1478
bf_page_change fires multiple times on inital page load #1468
Update pageView data layer variable to differentiate between form pages and eligible and ineligible benefits #1477

User Testing

  • navigate to /death
  • apply values to all required fields
  • for all radio inputs, select NO ( this ensures no benefits view)
  • console.log(window.dataLayer)

you should end up with an array of objects that follow this format

[
    {
        "nodeID": "1984",
        "contentType": "basic_page",
        "language": "en",
        "homepageTest": "not_homepage",
        "basicPagesubType": "Navigation Page"
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-intro",
            "viewTitle": "Benefit finder: death of a loved one"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-1",
            "viewTitle": "About the applicant"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-2",
            "viewTitle": "About the deceased"
        }
    },
    {
        "event": "bf_modal_open",
        "bfData": {
            "modalOpen": true
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-verify-selections",
            "viewTitle": "Review and confirm"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-result-view",
            "viewTitle": "You are likely not eligible for benefits",
            "viewState": "bf-eligible-view-zero-benefits"
        }
    },
    {
        "event": "bf_count",
        "bfData": {
            "eligible": 0,
            "moreInfo": 0,
            "notEligible": 30
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-result-view",
            "viewTitle": "You are likely not eligible for benefits",
            "viewState": "bf-not-eligible-view-zero-benefits"
        }
    }
]
  • confirm that our bf_page_change event is bf-eligible-view-zero-benefits
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-result-view",
            "viewTitle": "You are likely not eligible for benefits",
            "viewState": "bf-eligible-view-zero-benefits"
        }
    },
  • confirm that in the count we have 0 eligible benefits
    {
        "event": "bf_count",
        "bfData": {
            "eligible": 0,
            "moreInfo": 0,
            "notEligible": 30
        }
    },
  • confirm inital load dataLayer object that comes from USAGov node

// Initial load from USAGov node page

    {
        "nodeID": "1984",
        "contentType": "basic_page",
        "language": "en",
        "homepageTest": "not_homepage",
        "basicPagesubType": "Navigation Page"
    },

// Initial load from BF application intro view

    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-intro",
            "viewTitle": "Benefit finder: death of a loved one"
        }
    },

// incrementing steps values as pageView numerics in the dataLayer

    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-1",
            "viewTitle": "About the applicant"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-2",
            "viewTitle": "About the deceased"
        }
    },
  • To test Create a unique data layer value for the modal  #1478, we should only see the "event": "bf_modal_open", has been pushed by itself, we should not have additional pushes of "event": "bf_page_change" with the value of "pageView": "bf-form-2" having been pushed again
    {
        "event": "bf_modal_open",
        "bfData": {
            "modalOpen": true
        }
    },
  • navigate back to the beginning of the form by pressing the back link at the top of each view
Screenshot 2024-06-25 at 1 55 07 PM
  • for all radio inputs, select YES ( this ensures an eligible benefits view)
  • console.log(window.dataLayer)

you should end up with additional objects in the array that follow this format

[
  ...
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-2",
            "viewTitle": "About the deceased"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-1",
            "viewTitle": "About the applicant"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-form-2",
            "viewTitle": "About the deceased"
        }
    },
    {
        "event": "bf_modal_open",
        "bfData": {
            "modalOpen": true
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-verify-selections",
            "viewTitle": "Review and confirm"
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-result-view",
            "viewTitle": "Your potential benefits",
            "viewState": "bf-eligible-view"
        }
    },
    {
        "event": "bf_count",
        "bfData": {
            "eligible": 5,
            "moreInfo": 11,
            "notEligible": 14
        }
    },
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-result-view",
            "viewTitle": "Benefits you did not qualify for",
            "viewState": "bf-not-eligible-view"
        }
    }
]
  • confirm that our bf_page_change event is bf-eligible-view
    {
        "event": "bf_page_change",
        "bfData": {
            "pageView": "bf-result-view",
            "viewTitle": "Your potential benefits",
            "viewState": "bf-eligible-view"
        }
    },
  • confirm that in the count we have eligible benefits
    {
        "event": "bf_count",
        "bfData": {
            "eligible": 5,
            "moreInfo": 11,
            "notEligible": 14
        }
    },

Add data layer value to track benefit accordion open #1466

  • navigate to /death
  • complete required fields
  • answer YES to all radio fields
  • in the results CLICK a benefit accordion
  • in the open accordion click the button as a link, this should take you to an external site
  • return to the application and console.log(window.dataLayer)
  • confirm that the benefit you clicked is open and an"event": "bf_benefit_link", is in the dataLayer array that includes its title value
[
  ...
    {
        "event": "bf_benefit_link",
        "bfData": {
            "benefitTitle": "COVID-19 funeral assistance"
        }
    }
  ...
]

Create data layer event to track benefit link click #1467

  • navigate to /death
  • complete required fields
  • answer YES to all radio fields
  • in the results CLICK a benefit accordion
  • console.log(window.dataLayer)
  • confirm that the benefit you clicked is open and an"event": "bf_benefit_click", is in the dataLayer array that includes its title value
[
   ...
    {
        "event": "bf_benefit_click",
        "bfData": {
            "benefitTitle": "COVID-19 funeral assistance"
        }
    },
]
  • CLICK the same benefit accordion to close it

  • console.log(window.dataLayer)

  • confirm that the benefit you clicked is closed and no new "event": "bf_benefit_click", is in the dataLayer array

  • CLICK the same benefit accordion to open it, and CLICK a secondary benefit to also open

  • console.log(window.dataLayer)

  • confirm that the two (2) benefit you clicked are open and an "event": "bf_benefit_click", is in the dataLayer array that includes its title value

a11y improvements

a11y | Fonts are not scaling on magnification #1452

Chrome: Open Settings or Preferences and change the font size to Very large or Very small.

Previous
Example at "Very Large"
Image

Expected
Screenshot 2024-06-24 at 12 14 18 PM

Custom Module Improvements

Disable auto json file generation in multi-content action #1338

To test in local development site or in dev site.

  • pull changes locally
  • make local development site up at http://localhost
  • navigate to admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • select several criteria
  • select "Publish content" in action list
  • click "Apply to selected items" button
  • verify that the system not generating json files
  • verify that the system displays warning message

Xavier Metichecchia and others added 30 commits May 29, 2024 12:38
PXBF-ensure-prod-checkout: ensure prod checkout when moved
PXBF-1300-migrate-automated-nightly: remove migrated tests
scottqueen-bixal and others added 25 commits June 25, 2024 13:44
… when users click obfuscated links in accordions
…-event

1427 add search title field in life event
…tents-action

1338 disable auto json file generation in multi-content action
PXBF-PXBF-fix-lint-error: fix lint error
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review June 27, 2024 14:23
@scottqueen-bixal scottqueen-bixal merged commit d00590b into main Jun 27, 2024
16 checks passed
@scottqueen-bixal scottqueen-bixal changed the title Release v0.5.0.beta.1 Release v0.5.0.beta.1 (sprint 34) Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants