-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.6.2 (Sprint 40) #1782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v0.6.1.beta.1
…ed before handling to error state
PXBF-dev: Add continue on error to failing step
FIX: Error handling on required fields not persisting with default select options
…levant benefits cards
replace all benefits icon
scottqueen-bixal
requested review from
XavierMetichecchia and
nehemiah-abuga
September 5, 2024 18:28
nehemiah-abuga
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
https://github.com/GSA/px-benefit-finder/milestone/12?closed=1
Related Github Issue
Application improvements
Error handling on required fields not persisting with default select options #1772
Design improvements
replace all_benefits icon #1779
Detailed Testing steps
Application improvements
Error handling on required fields not persisting with default select options #1772
/death
--Select--
from the now valid inputreference the bug report in https://github.com/orgs/GSA/projects/48/views/10?pane=issue&itemId=78753927 and ensure this is resolved and no longer happening.
<select />
input--Select--
from the now valid inputexpected:
Screen.Recording.2024-08-30.at.10.08.22.AM.mov
all_benefits
node/all_benefits
--Select--
from the now invalid input--Select--
from the now invalid inputexpected:
Screen.Recording.2024-08-30.at.10.15.21.AM.mov
Design improvements
replace all_benefits icon #1779
all_benefits
andes_all_benefits
nodesadmin/content?combine=&type=bears_life_event_form&status=All&langcode=All
previous
updated