Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.6.2 (Sprint 40) #1782

Merged
merged 17 commits into from
Sep 5, 2024
Merged

Release v0.6.2 (Sprint 40) #1782

merged 17 commits into from
Sep 5, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Sep 5, 2024

PR Summary

https://github.com/GSA/px-benefit-finder/milestone/12?closed=1

Related Github Issue

Application improvements

Error handling on required fields not persisting with default select options #1772

Design improvements

replace all_benefits icon #1779

Detailed Testing steps

Application improvements

Error handling on required fields not persisting with default select options #1772

  • navigate to /death
  • CLICK continue without providing any values
  • ensure error alert is rendered
  • SELECT a month value from the date fieldset
  • ensure the error notification for month is cleared
  • SELECT the default option --Select-- from the now valid input
  • ensure the error is flagged and the DOM updates as expected

reference the bug report in https://github.com/orgs/GSA/projects/48/views/10?pane=issue&itemId=78753927 and ensure this is resolved and no longer happening.

  • SELECT an option from a fieldset with <select /> input
  • ensure the error is cleared
  • SELECT the default option --Select-- from the now valid input
  • ensure the error is flagged and the DOM updates as expected

expected:

Screen.Recording.2024-08-30.at.10.08.22.AM.mov
  • publish all_benefits node
  • navigate to /all_benefits
  • on the first step of the form, SELECT a month value from the date fieldset
  • CLICK continue
  • ensure that the error alert is rendered
  • SELECT the default option --Select-- from the now invalid input
  • ensure that the error alert is cleared
  • CLICK continue
  • ensure that you can proceed to the next step
  • CLICK back to return to the first step
  • SELECT a month value from the date fieldset
  • CLICK continue
  • ensure that the error alert is rendered
  • SELECT the default option --Select-- from the now invalid input
  • ensure that the error alert is cleared
  • enter a day value to the date fieldset
  • CLICK continue
  • ensure that the error alert is rendered

expected:

Screen.Recording.2024-08-30.at.10.15.21.AM.mov

Design improvements

replace all_benefits icon #1779

  • publish all_benefits and es_all_benefits nodes
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved" edit page
  • CLICK "Add Relevant Benefit"
Screenshot 2024-08-28 at 6 43 05 PM
  • Select life event form "Benefit finder: all benefits"
  • Add link "/benefit-finder/all-benefits"
  • CLICK Save to generate JSON files
  • Navigate to life event "Benefit finder: death of a loved one" in draft mode benefit-finder/death?mode=draft
  • Fill form to get into result page
  • Ensure the all benefits icon is displayed in both relative benefits cards

previous
Image

updated
Image

@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review September 5, 2024 18:20
Xavier Metichecchia and others added 2 commits September 5, 2024 14:21
@scottqueen-bixal scottqueen-bixal merged commit 84c1faa into main Sep 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants