Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.8.0.beta.1 (Sprint 43) #1903

Merged
merged 17 commits into from
Oct 30, 2024
Merged

Release v0.8.0.beta.1 (Sprint 43) #1903

merged 17 commits into from
Oct 30, 2024

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Oct 30, 2024

PR Summary

Related Github Issue

Remove data-analytic* attributes from DOM #1507

Custom Module Improvements

Do not archive criteria if still used #1866
do not archive life event form if still used #1902

Detailed Testing steps

  • navigate through app providing values
  • On results page, inspect DOM
  • ensure the following data attributes have been updated
data-analytics* 
data-analytics-content*

have been removed or replaced by

data-test-results-view*

Custom Module Improvements

Do not archive criteria if still used #1866

  • Navigate to admin/content?combine=&type=bears_criteria&status=All&langcode=All
  • Go to criteria "Applicant date of birth" edit page
  • Change to Archived
  • CLICK Save
  • Verify error message with list of benefits and life event forms that use this criteria

do not archive life event form if still used #1902

  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Change to Archived
  • CLICK Save
  • Verify error message

scottqueen-bixal and others added 15 commits October 18, 2024 10:20
Update stylesheets to include alias
1866 do not archive criteria if still used
…-if-used

1867 do not archive life event form if still used
@scottqueen-bixal scottqueen-bixal changed the title Release v0.8.0.beta.1 (Sprint 42) Release v0.8.0.beta.1 (Sprint 43) Oct 30, 2024
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review October 30, 2024 17:37
Copy link
Collaborator

@XavierMetichecchia XavierMetichecchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@XavierMetichecchia XavierMetichecchia merged commit 2a13c83 into main Oct 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants