Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXBF-2039-phpstan-fixes #2042

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

PXBF-2039-phpstan-fixes #2042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94d6a91
PXBF-2039-phpstan-fixes: fix greater always true
gchi25 Jan 9, 2025
6110c6d
PXBF-2039-phpstan-fixes: remove |null
gchi25 Jan 9, 2025
0b544a9
PXBF-2039-phpstan-fixes: fix phpstan error unknown parameter
gchi25 Jan 9, 2025
30fce3f
PXBF-2039-phpstan-fixes: fix type
gchi25 Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...v_benefit_finder/modules/usagov_benefit_finder_api/src/Controller/LifeEventController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ class LifeEventController extends ControllerBase {
/**
* The display data control variable.
*
* @var string
* @var bool
*/
protected $displayData;
protected bool $displayData;

/**
* The benefit finder content mode.
Expand All @@ -85,11 +85,11 @@ class LifeEventController extends ControllerBase {
* The entity type manager.
* @param \Drupal\Core\File\FileSystemInterface $file_system
* The file system service.
* @param \Drupal\file\FileRepositoryInterface|null $file_repository
* @param \Drupal\file\FileRepositoryInterface $file_repository
* The file repository.
* @param \Drupal\Core\File\FileUrlGeneratorInterface $file_url_generator
* The file URL generator.
* @param \Drupal\Core\Database\Connection $connection
* @param \Drupal\Core\Database\Connection $database
* The database connection.
* @param \Symfony\Component\HttpFoundation\RequestStack $request_stack
* The request stack.
Expand Down
4 changes: 2 additions & 2 deletions ...nefit_finder/modules/usagov_benefit_finder_content/src/Controller/CheckDataController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,11 @@ class CheckDataController extends ControllerBase {
* The entity type manager.
* @param \Drupal\Core\File\FileSystemInterface $file_system
* The file system service.
* @param \Drupal\file\FileRepositoryInterface|null $file_repository
* @param \Drupal\file\FileRepositoryInterface $file_repository
* The file repository.
* @param \Drupal\Core\File\FileUrlGeneratorInterface $file_url_generator
* The file URL generator.
* @param \Drupal\Core\Database\Connection $connection
* @param \Drupal\Core\Database\Connection $database
* The database connection.
* @param \Symfony\Component\HttpFoundation\RequestStack $request_stack
* The request stack.
Expand Down
2 changes: 1 addition & 1 deletion ...benefit_finder/modules/usagov_benefit_finder_content/usagov_benefit_finder_content.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function usagov_benefit_finder_content_form_alter(&$form, &$form_state, $form_id
$form['field_b_eligibility']['widget'][$i]['subform']['field_b_criteria_key']['widget']['#options'];
}
$i++;
} while ($i > 0);
} while (TRUE);
}
}

Expand Down
Loading