Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.9.0 #2048

Merged
merged 236 commits into from
Jan 10, 2025
Merged

Release v0.9.0 #2048

merged 236 commits into from
Jan 10, 2025

Conversation

scottqueen-bixal
Copy link
Collaborator

@scottqueen-bixal scottqueen-bixal commented Jan 10, 2025

PR Summary

Benefit Finder Release v0.9.0

Related Github Issue

https://github.com/GSA/px-benefit-finder/milestone/15?closed=1

Design Updates

Design | Mobile Layout Updates #1954
Design and content changes to the Landing Page of the Benefit Finder #1897
Redesign | Container widths #1778
Redesign | Mobile Typography #1776
Mobile Screens | Accordion Results #1839

Application updates

Function added to the BF Accordion Cards "More info needed" #1975
flashing button group on re-render #1996

Custom Module Improvements

Remove Criteria Group #1492
Prevent content developer from creating nested parent child relationships #1850
Remove role attribute #1979

Detailed Testing steps

Design Updates

Design updates were reviewed and approved by USAGov and Benefit Finder Design team duirng the Benefit Finder QA sprint

Application updates

Function added to the BF Accordion Cards "More info needed" #1975

  • navigate to /death
  • provide required values
  • navigate to list of benefit accordions
  • ensure that any of the following conditionals results in rendering the "Go back to start" cta
  1. not-eligible view in the more info needed accordions
  2. not-eligible view in the not-eligible accordions that also have more info needed listed
  • when clicked the user should be navigated back to the first step of the form with the previous selections still in value

flashing button group on re-render #1996

Detailed Testing steps

  • navigate to final step of form
  • toggle values in fieldset
  • ensure button group does not "flash"

previous:

Screen.Recording.2024-12-10.at.11.34.02.AM.mov

expected update:

Screen.Recording.2024-12-16.at.2.16.27.PM.mov

Custom Module Improvements

Remove Criteria Group #1492

  • If in local, bin/drush cim
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Go to criteria "Applicant date of birth"
  • Verify no Add criteria group button in criteria
  • Go to "Deceased service status"
  • Verify no Add criteria group button in children of criteria

Prevent content developer from creating nested parent child relationships #1850

  • Navigate to node/add
  • Click Add Criteria to add a criteria as following
  • Title: depth 0 criteria
  • Criteria Key: depth_0_criteria
  • ID: depth_0_criteria
  • Type: Boolean
  • Label: Depth 0 criteria
  • Name: Depth 0 criteria
  • Values: 1) Yes 2) No
  • Check Has Child
  • Input Yes in Child dependency options
  • Click Save as Published
  • Follow same steps to create depth 1, depth 2, and depth 3 criteria
  • Navigate to admin/content?combine=&type=bears_life_event_form&status=All&langcode=All
  • Go to life event form "Benefit finder: death of a loved one" edit page
  • Go to section "About you" to add criteria "depth 0 criteria"
  • Add criteria "depth 1 criteria" as child of "depth 0 criteria"
  • Add criteria "depth 2 criteria" as child of "depth 1 criteria"
  • Add criteria "depth 3 criteria" as child of "depth 2 criteria"
  • Click Save
  • Verify error message about criteria depth >1

Remove role attribute #1979

  • Navigate to benefit-finder/death
  • Inspect
  • Verify no role attribute in header and main

image

Xavier Metichecchia and others added 30 commits November 14, 2024 10:29
PXBF-1930-cypress-lint-error-resolve: resolve cypress lint error
PXBF-1929-remove-component-js-file: remove unused component files
PXBF-1928-cypress-page-objects-alpha-order: organize page object methods in alpha order
Xavier Metichecchia and others added 27 commits January 6, 2025 14:12
PXBF-2031-adjust-template-spacing-footer: more specificity
PXBF-2031-adjust-template-spacing-footer: more specificity
PXBF-2031-adjust-template-spacing-footer: update bottom padding
Release v0.9.0 (Sprint 48)
HOTFIX | v0.9.0 (sprint 48)
#2046 Add "|| true" to remove command for usagov_login
@scottqueen-bixal scottqueen-bixal self-assigned this Jan 10, 2025
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review January 10, 2025 15:30
@github-actions github-actions bot merged commit b173def into release Jan 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants