2058 firefox hash bug fix #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2055 gtm debug script
…s' of github.com:GSA/px-benefit-finder into 2058-firefox-hash-bug-fix
…uses bug in firefox browser history
nehemiah-abuga
approved these changes
Jan 22, 2025
|
@scottqueen-bixal - Now test are passing in Firefox as well. This issue has been resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Firefox stores hash history differently than other browsers, ie. chrome. Because of this, when we reset the hash state to an empty string when the modal is open we got an empty appended hash to the url in Firefox history. Now that we are using the client router we may not need that hash reset. Removing.
Related Github Issue
Detailed Testing steps