경기 조회 API #151
Merged
경기 조회 API #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 2 commits
April 13, 2024 18:38
tlsgmltjd
reviewed
Apr 14, 2024
Comment on lines
72
to
78
| betting.get().getBetPoint(), | ||
| matchResult.getTeamAScore(), | ||
| matchResult.getTeamBScore(), | ||
| betting.get().getBetScoreA(), | ||
| betting.get().getBetScoreB(), | ||
| match.getTeamABet(), | ||
| match.getTeamBBet() |
There was a problem hiding this comment.
배팅을 하지 않았다면 해당 값이 null로 나와서 NPE이 발생해요!
tlsgmltjd
reviewed
Apr 14, 2024
| match.getTeamABet(), | ||
| match.getTeamBBet(), | ||
| matchResult.getTeamAScore(), | ||
| matchResult.getTeamAScore(), |
There was a problem hiding this comment.
Suggested change
| matchResult.getTeamAScore(), | |
| matchResult.getTeamBScore(), |
B팀 점수인데 A팀 점수가 들어가네요!
Comment on lines
82
to
102
| return new MatchResultDto( | ||
| match.getMatchId(), | ||
| match.getMatchType(), | ||
| match.getMatchLevel(), | ||
| match.getTeamA().getTeamId(), | ||
| match.getTeamA().getTeamName(), | ||
| match.getTeamAGrade(), | ||
| match.getTeamAClassType(), | ||
| match.getTeamB().getTeamId(), | ||
| match.getTeamB().getTeamName(), | ||
| match.getTeamBGrade(), | ||
| match.getTeamBClassType(), | ||
| betting.isPresent(), | ||
| match.getTeamABet(), | ||
| match.getTeamBBet(), | ||
| matchResult.getTeamAScore(), | ||
| matchResult.getTeamAScore(), | ||
| betting.get().getBetScoreA(), | ||
| betting.get().getBetScoreB(), | ||
| calculatePoint.getEarnedPoint(), | ||
| calculatePoint.getLosePoint() |
There was a problem hiding this comment.
이렇게 생성자에 많은 필드를 주입하는것 보다 buidler 패턴을 사용하는것이 좋을것 같아요!
tlsgmltjd
reviewed
Apr 14, 2024
Comment on lines
+36
to
+38
| UserEntity currentUser = userFacade.getCurrentUser(); | ||
| List<MatchEntity> matches = matchQueryDslRepository.findByMonthAndDay(month, day); | ||
| List<MatchResultEntity> matchResults = matchResultQueryDslRepository.findByMonthAndDay(month, day); |
There was a problem hiding this comment.
경시 시작 시간, 끝나는 시간 값을 이용하여
matches: 경기 시작 전 or 경기 중인 경기
matchResults: 경기 시간이 끝난 경기
이렇게 조회되도록 변경 부탁드려요! 현재 상황은 경기 시간이 끝난 경기가 하나 있는데 matchs와 matchResults 모두 하나씩 나옵니다!
시간을 계산하여 한 쪽에서만 나오도록 변경 부탁드려요!
{
"match_id": 1,
"match_type": "SOCCER",
"match_level": "TRYOUT",
"team_aid": 36,
"team_aname": "팀8",
"team_agrade": "ONE",
"team_aclass_type": "SW",
"team_bid": 37,
"team_bname": "팀9",
"team_bgrade": "TWO",
"team_bclass_type": "SW",
"team_abet": 50000,
"team_bbet": 80000,
"team_ascore": 2,
"team_bscore": 2,
"bet_team_ascore": 3,
"bet_team_bscore": 2,
"earned_point": 117000,
"lose_point": null,
"vote": true
}실제 json 값인데 명세서와 다른 부분이 다수 존재합니다! 해당 부분 수정 부탁드리고 도저히 안될것 같은 부분이 있다면 따로 디스코드로 공유 후에 명세서를 변경하여 맞춰주세요! |
tlsgmltjd
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.