Fixed essentia level maintaining #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You could previously level maintain the thaumic energistics fake essentia item, but this wouldn't work properly due to the continuous buildup of the fake items. It would work initially, but once you added or removed any essentia, it would not make more. To fix this, this commit checks if the maintained item is an essentia stack and does two things. First, it will convert NEI addon aspects to thaumic energistics. This is because it's very difficult to get the thaumic energistics item (to configure maintainers). I tried to add some logic to AE's SlotFake that converts addon aspects to thaumic energistics aspects, but it broke level maintainers. It added very little, so I removed that. Second, it will check the essentia cache to get the stack size instead of the item cache.
RecursivePineapple
added
bug
|
|
OneEyeMaker
requested changes
Jan 9, 2025
src/main/java/com/glodblock/github/crossmod/thaumcraft/ThaumicEnergisticsCrafting.java
Show resolved
Hide resolved
src/main/java/com/glodblock/github/common/tile/TileLevelMaintainer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/glodblock/github/crossmod/thaumcraft/ThaumicEnergisticsCrafting.java
Show resolved
Hide resolved
src/main/java/com/glodblock/github/crossmod/thaumcraft/ThaumicEnergisticsCrafting.java
Outdated
Show resolved
Hide resolved
chochem
reviewed
Jan 11, 2025
src/main/java/com/glodblock/github/common/tile/TileLevelMaintainer.java
Outdated
Show resolved
Hide resolved
OneEyeMaker
approved these changes
Jan 14, 2025
serenibyss
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could previously level maintain the thaumic energistics fake essentia item, but this wouldn't work properly due to the continuous buildup of the fake items. It would work initially, but once you added or removed any essentia, it would not make more.
To fix this, this commit checks if the maintained item is an essentia stack and does two things.
First, it will convert NEI addon aspects to thaumic energistics. This is because it's very difficult to get the thaumic energistics item (to configure maintainers).
Side note: I tried to add some logic to AE's SlotFake that converts addon aspects to thaumic energistics aspects, but it broke level maintainers. It added very little, so I scrapped that idea and just made level maintainers treat the two fake essentia items the same.
Second, it will check the essentia cache to get the stack size instead of the item cache. Since essentia exists in its own cache, you cannot check the item cache to find its stored quantity. It would also be possible to check the fluid cache, but there wasn't much point since it was trivial to access the essentia cache instead.
The thaumic energistics item aspect is still needed to craft the essentia, so we only need to get the essentia stack size.