Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ArrayOutOfBounds in F3 debug text handler #736

Merged
merged 2 commits into from
Nov 17, 2024
Merged

fix ArrayOutOfBounds in F3 debug text handler #736

merged 2 commits into from
Nov 17, 2024

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Nov 17, 2024 •
edited
Loading

If a mod cancels the RenderGameOverlayEvent.Pre for type == DEBUG, the lists event.left and event.right will be empty, therefore we need to check the sizes before adding to a specific index.

@mitchej123 mitchej123 merged commit 912e0e8 into master Nov 17, 2024
1 check passed
@mitchej123 mitchej123 deleted the fix-crash branch November 17, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embeddedt embeddedt embeddedt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexdoru @embeddedt @mitchej123