Backport MemoryStack to reduce direct buffer allocations #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will re-add as needed
Fixes a clinit crash and makes it easier to compare to upstream
ah-OOG-ah
requested review from
eigenraven,
Cleptomania,
mitchej123 and
embeddedt
mitchej123
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. There's probably some repeated buffer allocations I missed, but I patched the ones I could grep for plus the only one that kept appearing in my crash reports. There's another persistent one from Avaritia, so I will probably pull this out into GTNHLib in a follow-up PR.