Fix/same network multiple extract only storage buses #612
+104
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same network will only have one of them work
… without filter reading from the same network
|
Drafted until I fix the issue with items in cyclic storage bus setups being attributed to the wrong network. |
|
Created a new issue for GTNewHorizons/GT-New-Horizons-Modpack#18074. Currently I cannot see a solution for it without large changes to AE2. The cause for both issues is the same, that the network is only read once. This PR however will still fix the issue of having multiple storage buses in extract-only reading from the same network and as such I reopened it. |
serenibyss
reviewed
Dec 27, 2024
| if (!networkInventoryItems.containsKey(networkInventoryHandler)) { | ||
| IItemList<T> allAvailableItems = this.getInternal() | ||
| .getAvailableItems((IItemList<T>) this.getInternal().getChannel().createList(), iteration); | ||
| networkInventoryItems.put(networkInventoryHandler, allAvailableItems); |
There was a problem hiding this comment.
How is this cache getting invalidated?
There was a problem hiding this comment.
Every time the iteration number changes the cache is replaced with a new one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#17950
The available items in a network connected via a extract-only storage bus are only read once, a second attempt via another storage bus attempt will return early without checking the items since the network was already visited before.
This PR will make it so that the
StorageBusInventoryHandlercaches the items for the current iteration and from which network(s) it retrieved them.