Cleaned up Throwable try catches #3280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RecursivePineapple
added
the
refactor
YannickMG
reviewed
Sep 25, 2024
boubou19
added
the
ongoing freeze - do not merge
Lyfts
reviewed
Sep 27, 2024
| @@ -600,7 +600,7 @@ public void onLoadComplete(FMLLoadCompleteEvent aEvent) { | |||
| try { | |||
| tRunnable.run(); | |||
There was a problem hiding this comment.
Can we please ditch some more of these random Throwable catches, especially the ones around the pre, post etc. Runnables.
I had a bitch of a time the other day trying to figure out why my code was seemingly doing nothing, only to realise that GT5U was silently catching otherwise useful exceptions. These runnables are used in many different places and this makes debugging them much more annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a large number of Throwable try/catches. Several important try/catches were given a better error message.
This was tested in the latest nightly and it worked fine. I placed a few machines to make sure nothing important was broken, although many of the try/catches had no explanation. If they prevented a crash due to a bug, I have no way of verifying that the bug is still present.