Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old 32x/64x/png/gradiented circuitry textures with better 16x ones #3509

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

bluhbipo
Copy link
Member

@bluhbipo bluhbipo commented Nov 17, 2024

Mainframes suck. among other things
they're ugly
i have made them better
BEFORE
image
AFTER
image
*note, the photonically enriched wafer is animated correctly, this screencap is just of a bad frame

all pngs and 32x nonsense has been boomed and replaced with beautiful functionally identical 16x textures

the mainframe is of particular importance that its shape was mimiced as well as possible, since people often dislike change and mainframes are a core aspect of the game. the design we came up with was workshopped over several hours through the intellectual contributions of several texture dev and main dev people.

here is what the new optical mainframe looks like fully animated:

opticalmainframe

i do not have the resources to figure out how the hell to screen record. majority of the circuits are still animated ala the previous change by the wonderful terra, but i did not animate textures that i did not believe i could faithfully represent in 256 pixels. this is a job for someone who isnt me

t3 circuits, the computers remain non 16x. why? because they fit in the art style and are too iconic to change. i grappled with perhaps extending the texture of the workstation to all other tiers because i like how it looks, but again, i do not want to poke the hornets nest of "old thing good, new thing bad"

the wafer texture was again workshopped over days via the intellectual contributions of many devs both of texture and code alike. the cut wafer texture sucks but its whatever at least it is not a 64x monstrosity

the earlygame circuit components have been made to look not stupid and png, and later on, glass tubes for all your wetware board needs no longer look ugly as all hell.

this modpack is worthy of the polish that a modern minecraft modpack deserves, and as such, the coloring and shading on the old circuit textures that arent mainframes have been updated in line with a modern understanding of pixel art color theory. wetwares appear more pink because it looks like flesh and we all thought that was cute.

this pr has a portion of it already accepted, for the new masks for beamline. also. i dont know where the pico wafers are stored but they will need to have their textures updated too.

THIS PR IS now tested! yippee!!.

credit to our resident epic artist bluehero for the gallium arsenide crystal textures.

@BlueHero233 BlueHero233 added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Nov 17, 2024
@Dream-Master Dream-Master added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 18, 2024
@Dream-Master Dream-Master requested a review from a team November 18, 2024 07:30
Copy link
Member

@GDCloudstrike GDCloudstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After going through multiple feedback cycles, I think this turned out great

Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We not add this in 2.7.0
Some changes i not agree with. I will give a detailed feedback later

@wlhlm
Copy link
Member

wlhlm commented Nov 20, 2024

Larger than 16px textures are a pet peeve of mine. Thank you for making the base textures more consistent. ❤️

@AbdielKavash
Copy link
Member

Could you post a picture of the glass tube/vacuum tube in a machine UI? One of my pet peeves is that the old texture blends into the machine slot background so well as to appear nearly invisible. I remember several people getting their circuit recipes wrong because they didn't even realize that a vacuum tube is needed from the NEI recipe. It would be nice to have this corrected as well.

@Dream-Master
Copy link
Member

Not get me wrong I appreciate the work get 16x16 icons for all this items but some items need a bit more work and some changes . As I said I will add a more detailed feedback but not today .

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 8, 2025
@Dream-Master
Copy link
Member

@bluhbipo i just testing this ingame to give a better feedback and it is included in the gt pre tags so thers can test as well.
When i done i let you know if and what need to be changed.

@bluhbipo
Copy link
Member Author

bluhbipo commented Jan 9, 2025

thanks @Dream-Master !

@Dream-Master
Copy link
Member

@bluhbipo
boards are fine
about the circuits why do you change the color from the red one and the green one(Wetware processor quantum processor)
the dots on the wafers/bouls looks now a bit strange since thy are biger because of the 16x16. Can you reduce the color intensity a bit?
samds and asmds are ok
capacitor, transitor need shadow back. now it looks very flat
Glass tube and vacuum tube looks very similar need a bit different looking otherwise you cant see which item you have
Bio Mainframe has no animation(before you see bubbles)
cosmic Mainframe seems to unchanged and have a 32x32 texture ?
Gallium Arsenic Crystal looks very crappy with 16x16 not sure how it can be improved

@bluhbipo
Copy link
Member Author

@Dream-Master i'll try to work on those, thank you!
the nano/quantum colors were changed to be less bad on the eyes, as they were both very close to rgb yellow and rgb green which is not very good looking. wetware became more pink because it looks like meat which i can change back if you do not like that. mainframes that do not yet exist in game were not textured but i can give them textures to keep up appearences in nei

@Dream-Master
Copy link
Member

@Dream-Master i'll try to work on those, thank you! the nano/quantum colors were changed to be less bad on the eyes, as they were both very close to rgb yellow and rgb green which is not very good looking. wetware became more pink because it looks like meat which i can change back if you do not like that. mainframes that do not yet exist in game were not textured but i can give them textures to keep up appearences in nei

sure i know they close to rgb max color but the new color not looks so nice. i would change it back to orginal value. I like the old color give them more indentification.
oh didnt check it not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants