Cribs super recipe check #3608
Open
Cribs super recipe check #3608
+172
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chochem
added
ongoing freeze - do not merge
Dream-Master
removed
the
ongoing freeze - do not merge
…ribs_super_recipe_check
…ribs_super_recipe_check
|
@lordIcocain can you run spotless |
|
Done |
…ribs_super_recipe_check
serenibyss
reviewed
Dec 13, 2024
src/main/java/gregtech/api/metatileentity/implementations/MTEMultiBlockBase.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/tileentities/machines/IDualInputInventory.java
Outdated
Show resolved
Hide resolved
...main/java/gregtech/common/tileentities/machines/multi/compressor/MTEBlackHoleCompressor.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/tileentities/machines/multi/MTEMultiSolidifier.java
Outdated
Show resolved
Hide resolved
miozune
reviewed
Jan 4, 2025
src/main/java/gregtech/common/tileentities/machines/MTEHatchCraftingInputME.java
Outdated
Show resolved
Hide resolved
| processingLogic.setInputFluids(slot.getFluidInputs()); | ||
| processingLogic.setCribsSlotHash(slotHash); | ||
|
|
||
| CheckRecipeResult foundResult = processingLogic.process(); |
There was a problem hiding this comment.
This is optional and you're perfectly ok to ignore; How about making MTEMultiBlockBase provide API for each multi to insert custom recipe process logic between CRIB and ordinary hatches, so that solidifier multi doesn't need to copy-paste all the logic from parent, just to insert solidifier hatch logic?
…ribs_super_recipe_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get pattern inputs
Find recipes in this machine recipe map
Save recipes in processingLogic using HashMap and slot.getHash() as key.
Machine recipe check will search for recipes in Map using slot.getHash() as key then performe recipeCheck for this single recipe.
Should improve endgame bases performance.