-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic heating coils #3951
base: master
Are you sure you want to change the base?
Dynamic heating coils #3951
Conversation
Alright, this is ready for review. I've been testing it in my survival server and it works pretty well. I'm relatively sure there aren't any trivial bugs in it. I've temporarily disabled shader interop since that relies on several other PRs and it's only 2 static method calls. I'll make another PR for that once this one gets merged and we figure out what we want to do with the textures/shaders for them. Since I can't distribute a modified complementary legally coils are pretty underwhelming now (even with PBR textures). I don't want to fork euphoria out of respect for the dev's efforts (since he specifically backported his patcher mod for angelica). |
Just a thing, for a very fast recipe that is processed in ticks ( in endgame) the coil will toggle every time from inactive to active, or it will wait some secs to "heat up" so it doesnt cause lag |
It'll turn on immediately, but updating isn't very laggy since it's just one packet and a chunk rebuild. I'd be more worried about tiggering someone's epilepsy, but I doubt people with that can play games anyways. Adding some sort of timer would complicate the code a lot more, but it's not impossible. |
@munequeen both of those problems should be fixed with my two recent commits. The former was just a misunderstanding on my part, and the latter was a poor design choice (easily fixed). You can fix the second problem by turning machines off and on again, it's a problem with the server -> client syncing. It's caused by one EBF turning on in the same tick that the other turns off. |
This improves the appearance of heating coils, primarily for shaders. Coils will now have two states: active and inactive.
When inactive, they look similar to their prior appearance. I desaturated the textures a bit - they're placeholders until a texture dev wants to improve them. The naq coils in particular need a lot of fixing, but I'm not sure what would be best.
When active, their heating elements will glow. This effect works without shaders, but it looks much better with shaders. I tweaked Sampsa's shaders a bit to fix the coil bloom and add some extra effects.
This effect is configurable, so if someone doesn't like the look of it they can turn it off completely in the gt5u mod config.
Screenshots & videos
Disabled (old textures, without any activity):


Inactive coils (no shaders):


Inactive coils (shaders):


Active coils (no shaders):



Active coils (shaders):



The low tier coils (trinium and down) have a slight pulsing effect. The higher tier coils are constant.
2025-02-14.17-11-59.mp4
I'm a big fan of how hypogen coils turned out, they look really cool IMO. I think eternal coils need a bit of an improvement since they look like a downgrade to me.
2025-02-14.17-20-52.mp4