Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic heating coils #3951

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Dynamic heating coils #3951

wants to merge 23 commits into from

Conversation

RecursivePineapple
Copy link
Contributor

@RecursivePineapple RecursivePineapple commented Feb 14, 2025

This improves the appearance of heating coils, primarily for shaders. Coils will now have two states: active and inactive.

When inactive, they look similar to their prior appearance. I desaturated the textures a bit - they're placeholders until a texture dev wants to improve them. The naq coils in particular need a lot of fixing, but I'm not sure what would be best.

When active, their heating elements will glow. This effect works without shaders, but it looks much better with shaders. I tweaked Sampsa's shaders a bit to fix the coil bloom and add some extra effects.

This effect is configurable, so if someone doesn't like the look of it they can turn it off completely in the gt5u mod config.

Screenshots & videos

Disabled (old textures, without any activity):
2025-02-14_17 18 08
2025-02-14_17 18 40

Inactive coils (no shaders):
2025-02-14_17 13 51
2025-02-14_17 14 08

Inactive coils (shaders):
2025-02-14_17 07 19
2025-02-14_17 05 56

Active coils (no shaders):
2025-02-14_17 14 29
2025-02-14_17 13 40
2025-02-14_17 15 43

Active coils (shaders):
2025-02-14_17 07 28
2025-02-14_17 08 19
2025-02-14_17 08 52

The low tier coils (trinium and down) have a slight pulsing effect. The higher tier coils are constant.

2025-02-14.17-11-59.mp4

I'm a big fan of how hypogen coils turned out, they look really cool IMO. I think eternal coils need a bit of an improvement since they look like a downgrade to me.

2025-02-14.17-20-52.mp4

@RecursivePineapple RecursivePineapple added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Feb 14, 2025
@RecursivePineapple RecursivePineapple requested a review from a team February 14, 2025 22:31
@RecursivePineapple RecursivePineapple marked this pull request as ready for review February 21, 2025 17:07
@RecursivePineapple
Copy link
Contributor Author

Alright, this is ready for review. I've been testing it in my survival server and it works pretty well. I'm relatively sure there aren't any trivial bugs in it. I've temporarily disabled shader interop since that relies on several other PRs and it's only 2 static method calls.

I'll make another PR for that once this one gets merged and we figure out what we want to do with the textures/shaders for them. Since I can't distribute a modified complementary legally coils are pretty underwhelming now (even with PBR textures). I don't want to fork euphoria out of respect for the dev's efforts (since he specifically backported his patcher mod for angelica).

@EnderProyects
Copy link
Contributor

EnderProyects commented Feb 21, 2025

Just a thing, for a very fast recipe that is processed in ticks ( in endgame) the coil will toggle every time from inactive to active, or it will wait some secs to "heat up" so it doesnt cause lag

@RecursivePineapple
Copy link
Contributor Author

It'll turn on immediately, but updating isn't very laggy since it's just one packet and a chunk rebuild. I'd be more worried about tiggering someone's epilepsy, but I doubt people with that can play games anyways.

Adding some sort of timer would complicate the code a lot more, but it's not impossible.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 27, 2025
@munequeen
Copy link

munequeen commented Mar 4, 2025

Unfortunately LCR's and multi smelter's coils do not glow.
image
image

@munequeen
Copy link

Zyngen preview in NEI is missing its coils. Same issue with volcanus, EBF, MEBF, pyrolyse oven, and possibly other structures. I'm on nightly 893.
image

@munequeen
Copy link

I don't know how this happened. When I first turned on EBF it was fine, but as I was running around I noticed this weirdness.
image

@RecursivePineapple
Copy link
Contributor Author

@munequeen both of those problems should be fixed with my two recent commits. The former was just a misunderstanding on my part, and the latter was a poor design choice (easily fixed). You can fix the second problem by turning machines off and on again, it's a problem with the server -> client syncing. It's caused by one EBF turning on in the same tick that the other turns off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants