Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share both research and discovered aspects list with the knowledge sharing tome #41

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Share both research and discovered aspects list with the knowledge sharing tome #41

merged 2 commits into from
Jul 17, 2024

Conversation

eigenraven
Copy link
Member

  • Refactor the knowledge sharing tome code to be a bit more readable and simplify some of the logic
  • Share both the researches (as before) and the discovered aspects list when using the book (so the person using the book doesn't have to scan items in order like the first person to discover all aspects) - without giving any research points.
  • Update buildscript and use RFG Tags instead of token replacement

@eigenraven eigenraven requested a review from a team July 17, 2024 16:33
@eigenraven eigenraven self-assigned this Jul 17, 2024
@eigenraven eigenraven enabled auto-merge (squash) July 17, 2024 16:37
@eigenraven eigenraven merged commit 6670fcd into master Jul 17, 2024
1 check passed
@eigenraven eigenraven deleted the share-aspect-research branch July 17, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees

@eigenraven eigenraven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eigenraven @serenibyss