Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade to angular5 #23

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

brendoncaulkins
Copy link

@brendoncaulkins brendoncaulkins commented Oct 20, 2018

Fixes #20 and #6

This is a WIP - and not ready for acceptance, yet.

I am unfamiliar with .Net, ASP, and the deployment methods used here, but the Angular portion has been upgraded and I've started restructuring the code into a more traditionally organized Angular app. There's more do to on that front, but at this stage the code compiles, so I'm interested in help/feedback before going much further.

@GaProgMan
Copy link
Owner

Fantastic. Thank you very much. I'm looking forward to seeing the final set of changes.

To be honest, I've been wanting to strip the .NET Core/ASP NET Core layer out from underneath this application and host it as an Angular application. I've done it with other apps, but I haven't had the chance to do it with this one.

It was first written when the ASP NET Core SPA services where released, you see.

@brendoncaulkins
Copy link
Author

Sure.

Honestly, if you want to do that it may be simpler to just start a new Angular project. You have business logic already figured out and can reference this project but it may feel nice to take a fresh go at things, especially if you want a pure Angular app.

Just a thought. I'm happy to continue to help, either way you go.

@GaProgMan
Copy link
Owner

I think you're right. It would be better as a clean sweep. I've been wanting to do it for a while, if I'm honest.

Thank you for the work on this so far, by the way.

@brendoncaulkins
Copy link
Author

Happy to help, even if it's just to help talk out options. How/ when you decide to proceed, just tag me of you would like any assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants