Add support for building GPU-enabled GalSim using NVIDIA compiler #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge this yet. A colleague who is testing GalSim on our cluster here has found a problem with the nvc++ support which I'll need to fix first. |
rmjarvis
reviewed
Aug 9, 2023
rmjarvis
approved these changes
Aug 11, 2023
rmjarvis
added
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for building with the NVIDIA compiler, nvc++. This compiler doesn't support one of the warnings commonly enabled in the other compilers so we have to remove it. It also formats its version information a little differently from gcc and clang.
This also adds a missing macro definition for building for GPU with gcc.