Move some of our test utilities to galsim.utilities #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeyers314
approved these changes
Aug 19, 2023
galsim/utilities.py
Outdated
|
|
||
|
|
||
| # Context to make it easier to profile bits of the code | ||
| class profile: |
There was a problem hiding this comment.
FWIW, I'd actually love to rename this one so it doesn't conflict with using @profile via line_profiler.
There was a problem hiding this comment.
OK. Suggestions? Maybe just capitalize? with Profile(): That would fit in with most of our GalSim style for classes.
There was a problem hiding this comment.
I was also thinking of renaming a couple others. do_pickle and all_objs_diff aren't great names either, tbh. I was thinking check_pickle and check_all_diff for those.
There was a problem hiding this comment.
Yeah, these all sound better to me.
| obj: The object to test | ||
| func: A function of obj to use to test for equivalence. [default: lambda x: x] | ||
| irreprable: Whether to skip the eval(repr(obj)) test. [default: False] | ||
| random: Whether the obj has some intrinsic randomness. [default: False, unless |
There was a problem hiding this comment.
Right. I was describing what that default means, which is False normally, but tries to notice randomness.
rmjarvis
added
admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the things that are in our galsim_test_helpers, I've used in other projects and just copied them over. It would be easier if these lived in galsim.utilities instead, so I could just use them directly. This PR puts the ones that I think are potentially useful for other project in our installed code base: