Add galsim.EmissionLine #1249
Merged
Add galsim.EmissionLine #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeyers314
force-pushed
the
emission_line
branch
from
33b454d
to
d2c16fb
Compare
rmjarvis
requested changes
Oct 6, 2023
galsim/sed.py
Outdated
|
|
||
| Parameters: | ||
| wavelength: The wavelength of the line. | ||
| fwhm: The full-width-half-max of the line. |
There was a problem hiding this comment.
This should probably have default too, I think. 1 nm or something.
| fwhm: The full-width-half-max of the line. | ||
| flux: The integrated flux of the line. [default: 1.0] | ||
| wave_type: The units of wavelength used for this SED. See SED | ||
| constructor for options. [default: 'nm'] |
There was a problem hiding this comment.
I guess this is just for fwhm. Maybe mention that here.
There was a problem hiding this comment.
It's for both the wavelength and fwhm arguments. I'll clarify.
There was a problem hiding this comment.
Of course. Yes, wavelength too. :)
jmeyers314
force-pushed
the
emission_line
branch
from
d2c16fb
to
cb0f508
Compare
rmjarvis
approved these changes
Oct 6, 2023
Closed
rmjarvis
added
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.