Add Eval type for gsobjects in config #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
approved these changes
Oct 10, 2023
|
Thank you! |
rmjarvis
commented
Oct 10, 2023
rmjarvis
added
feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggested to @beckermr that he use an Eval type for a GSObject for something, where that would be particularly convenient. Turns out we don't have one of those. This is an oversight on my part, since several other things do, leveraging the code for Evals of value types.
This PR remedies this oversight, so now you can use Eval as an object type to evaluate arbitrary strings as GSObjects.