Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Roman PSFs, throughputs, backgrounds, etc. to Phase C data (aka Cycle 9) #1251

Merged
merged 15 commits into from
Oct 12, 2023
Merged

Update Roman PSFs, throughputs, backgrounds, etc. to Phase C data (aka Cycle 9) #1251

merged 15 commits into from
Oct 12, 2023

Conversation

rmjarvis
Copy link
Member

Lots of updates here. I'll try to run through them all:

  • Diameter is now 2.36 m (was 2.37).
  • Exposure time is now 139.8 s (was 140.25).
  • Added information for filters R062 and K213.
  • Thermal backgrounds all changed (cf. https://roman.gsfc.nasa.gov/science/WFI_technical.html).
  • The wide filter is now called W146 (was W149).
  • New bandpasses from Roman_effarea_20201130.xlsx same site.
  • Updated sky levels to match the new bandpasses.
  • Updated Zernike aberrations to use same values used by WebbPSF. Specifically, the file webbpsf-data/WFI/wim_zernikes_cycle9.csv.
  • Updated the pupil plane images, also from the WebbPSF repo.
  • Updated WCS information using measured angles given in RST PhaseC (Pre CDR) WIMWSM Zernike and Field Data_20210204_d2.xlsx (available in our devel/roman directory).

rmjarvis and others added 14 commits October 4, 2023 23:26
@rmjarvis
Fix integer overflow error in maxptr calculation
e49d508 
(#1017)
@rmjarvis
exptime is 139.8 now
83ea517 
(#1017)
@rmjarvis
W149 is now W146
0248c53 
(#1017)
@rmjarvis
Diameter is officially 2.36m now, not 2.37 m.
13c5778 
(#1017)
@rmjarvis
Update filter throughputs and skybackground file
7eb81d3 
(#1017)
@rmjarvis
Update thermal backgrounds
eeaf262 
(#1017)
@rmjarvis
Hard-code rows for bilinear aberration interpolation, since x's,y's d…
4cab638 
…on't necessarily match.

(#1017)
@matroxel @rmjarvis
updates to PSF files and usage
c924b49
@rmjarvis
Update WCS to Phase C measurements
38896ff 
(#1017)
@rmjarvis
Update aberration continuity test
5d0523e 
(#1017)
@rmjarvis
Go back to having Roman bandpass be dimensionless using nominal roman…
d64c4b9 
….collecting_area.

(#1017)
@rmjarvis
Add items to CHANGELOG (and some mild cleanup)
8168cad 
(#1017)
@rmjarvis
Remove old wcs files
1924640 
(#1017)
@rmjarvis
coverage
6736c87 
(#1017)
This was referenced Oct 11, 2023
Open
Closed
@rmjarvis rmjarvis linked an issue Oct 11, 2023 that may be closed by this pull request
Add WFIRST R062 filter information to galsim.wfirst #1017
Closed
matroxel
matroxel reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@matroxel matroxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions about doc changes.

galsim/roman/roman_bandpass.py
``delta_zp`` will be a positive number that should be added to the GalSim zeropoints to compare
with externally calculated instrumental zeropoints. When using the GalSim zeropoints for
normalization of fluxes, the ``area`` kwarg to drawImage can be used to get the right
normalization (giving it the quantity ``area_eff`` calculated using the lines of code above).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc change should be reverted with the reversion of the collecting area change?

galsim/roman/__init__.py Outdated
@@ -25,21 +25,27 @@

gain = 1.0
pixel_scale = 0.11 # arcsec / pixel
diameter = 2.37 # meters
# Effective area now taken into account in the bandpass throughput (units of effective area, m^2) and sky background files.
# To modify these assumptions, remove approximate factor of eff_area = 0.25 * np.pi * diameter**2 * (1. - obscuration**2) in meters^2 and rescale to new values of these parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit ambiguous now that the 'mean' collecting_area has been taken out again internally. Should clarify that nothing has changed for the user if these are used within galsim, only if someone uses the files directly?

@rmjarvis
Copy link
Member Author

Yep. Good catches on those. I reverted those docs, since they aren't relevant anymore.

@rmjarvis rmjarvis added this to the v2.5 milestone Oct 12, 2023
@rmjarvis rmjarvis added roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module. inputs Related to input files used by GalSim, such as the cosmos data, SEDs, bandpasses, etc. labels Oct 12, 2023
@rmjarvis rmjarvis merged commit 39a878c into main Oct 12, 2023
9 checks passed
@rmjarvis rmjarvis deleted the #1017 branch October 12, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matroxel matroxel matroxel approved these changes

Assignees
No one assigned
Labels
inputs Related to input files used by GalSim, such as the cosmos data, SEDs, bandpasses, etc. roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module.
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.

Add WFIRST R062 filter information to galsim.wfirst
2 participants
@rmjarvis @matroxel