Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fftw on new Mac GHA machines #1288

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix fftw on new Mac GHA machines #1288

merged 1 commit into from
May 1, 2024

Conversation

rmjarvis
Copy link
Member

@rmjarvis rmjarvis commented May 1, 2024

The new MacOS runners on GitHub actions seem to have recently turned on "System Integrity Protection". This means the way we had been setting the FFTW include and link directories didn't work right anymore. We now need to explicitly set FFTW_DIR when doing pip install.

@rmjarvis rmjarvis added this to the v2.5 milestone May 1, 2024
@rmjarvis rmjarvis added build Related to compiling, building, installing tests Related to the test suite labels May 1, 2024
@jmeyers314
Copy link
Member

Yep. I think the location homebrew installs to is different for MacOS x86 and MacOS ARM too if we ever want to enable both in CI.

@rmjarvis
Copy link
Member Author

rmjarvis commented May 1, 2024

Thanks Josh!

@rmjarvis rmjarvis merged commit b913eeb into main May 1, 2024
10 checks passed
@rmjarvis rmjarvis deleted the fix_fftw branch May 1, 2024 15:33
@jmeyers314
Copy link
Member

Also note that the system clang on the GHA runners (both x86 and ARM) don't include OpenMP (https://github.com/GalSim-developers/GalSim/actions/runs/8911049524/job/24471556168#step:13:513).

I don't know if there's a "pro" side to disabling omp for CI, but to compile with it you can grab llvm from homebrew (which is the right thing to do for pypi uploads I think). See bits around https://github.com/jmeyers314/batoid/blob/releases/0.6/.github/workflows/wheels.yml#L90-L97.

@rmjarvis
Copy link
Member Author

rmjarvis commented May 1, 2024

Yeah, we should include the llvm download when we do the arm wheels.

@jmeyers314
Copy link
Member

Yeah, we should include the llvm download when we do the arm wheels.

I can't actually tell from the GHA logs, but I suspect we should do this for the x86 wheels too. I.e., I suspect the MacOS wheels currently on PyPI are single-thread only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to compiling, building, installing tests Related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants