Fix #1302 #1306
Merged
Fix #1302 #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmjarvis
added
bug report
rmandelb
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error found by @FedericoBerlfein that amounted to GSObjects missing a method needed to properly duck type as ChromaticObjects in some cases.
Specifically, if an inseparable chromatic object is convolved with a GSObject (in Federico's case, a Pixel), then a bit of code tries to call
_fiducial_profileon the separable components, which didn't work, since GSObject didn't have this method. The fix is simply to add a trivial version of that method so the GSObject duck types properly in this context.