Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dynamical simulation unit systems (G=1 or other value) #225

Merged
merged 14 commits into from
Oct 17, 2024
Merged

Add support for dynamical simulation unit systems (G=1 or other value) #225

merged 14 commits into from
Oct 17, 2024

Commits on Oct 16, 2024

  1. add simulation flag

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d11151a View commit details
    Browse the repository at this point in the history

  2. add logic to define unspecified unit using assumption about G

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c98119b View commit details
    Browse the repository at this point in the history

  3. add flags to namespace

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0914296 View commit details
    Browse the repository at this point in the history

  4. add test of sim usys

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    eb00224 View commit details
    Browse the repository at this point in the history

  5. Rename constructor to from_

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0e89a97 View commit details
    Browse the repository at this point in the history

  6. oops rebase error

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e240665 View commit details
    Browse the repository at this point in the history

  7. require a concrete value for G (i.e. not a unxt Quantity)

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bd8d843 View commit details
    Browse the repository at this point in the history

  8. add test of sim units

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4011d8c View commit details
    Browse the repository at this point in the history

  9. rename to dynamical simulation flag

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    201dca7 View commit details
    Browse the repository at this point in the history

  10. disable pylint error

    @adrn
    adrn committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a80ece9 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. only support float or int values of G

    @adrn
    adrn committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    23252d1 View commit details
    Browse the repository at this point in the history

  2. fix bug in logic

    @adrn
    adrn committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    cfa0fb0 View commit details
    Browse the repository at this point in the history

  3. add test of all pairs of base units with G=1

    @adrn
    adrn committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    35622cc View commit details
    Browse the repository at this point in the history

  4. shorten name of flags

    @adrn
    adrn committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a73f9e1 View commit details
    Browse the repository at this point in the history