Move the EchoArea into the Brick UI #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This didn't really need to be in the core, except that a few core functions explicitly generated echo area updates. This commit introduces a new policy that just reflects any non-debug log message (at least the first line) into the echo area. This means that the brick UI can just postprocess any log events and update the UI if needed. The result is a slight simplification and is logically a bit nicer. Fixes #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't really need to be in the core, except that a few core functions
explicitly generated echo area updates.
This commit introduces a new policy that just reflects any non-debug log
message (at least the first line) into the echo area. This means that the brick
UI can just postprocess any log events and update the UI if needed. The result
is a slight simplification and is logically a bit nicer.
Fixes #92