Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 14 sort, SMB3 shuffle, & bugfixes galore #101

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Java 14 sort, SMB3 shuffle, & bugfixes galore #101

wants to merge 27 commits into from

Conversation

warmCabin
Copy link

@warmCabin warmCabin commented Nov 18, 2023 •
edited
Loading

Sup? Been having some fun with this project lately. I'd be happy to split these out into multiple branches if you want to cherry pick.

New features:

Bug Fixes:

  • Highlights: Fix bounds checking in markArray and throw early.
    • Previously, it would accept indices over 32767 with no immediate problems and cause pernicious crashes down the line in clearAllMarks.
    • I've included a little test sort that intentionally causes the crash.
  • JEnhancedOptionPane: "Use default" no longer accepts your input.
  • ArrayManager: Improve error handling for custom distributions.
    • If the file is nonexistent, malformed, or the user just clicks cancel, the selection is rejected and the previous one remains.
  • ShufflePrompt, ShuffleDialog: Fix double update bugs in JList handlers
    • I'm not actually sure what tool was used to generate these files, but I don't think I stepped outside the proper bounds, here.
  • Perlin noise: Fix floating point error that lead the shuffler to sample a constant point
    • I just used Math.nextUp, which is basically just *(float*)(*((int*)&randomStart) + 1). The real fix is to use doubles.

@warmCabin
create Java 11 copypasta sort
c59a468
@warmCabin
rename to Java14Sort
267ac75 
I grabbed DualPivotQuickSort by ctrl+clicking into Arrays.sort. Turns out I had
my IDE settings pointing to Java 14 for this project, even though maven was set
to use Java 11. Why is IntelliJ like this?
@warmCabin
fix IndexOutOfBoundsException
c43f375 
I'm going to make markArray throw these early.
@warmCabin
add more bounds checking to Highlights.markArray()
a2ff108
@warmCabin
just throw IndexOutOfBoundsExceptions
661c77d
@warmCabin
add SMB3 Shuffle
519dd2d
@warmCabin
document leftRotation
e977376
@warmCabin
first pass at minimizing parameters
272beab
@warmCabin
second pass at minimizing parameter clutter
65bd221
@warmCabin
"Use default" no longer accepts your input
36e090e 
UNINITIALIZED_VALUE means the textbox was empty. This method never actually
checked which button was clicked.
@warmCabin
fix Distribution naming issues
383c3e6
@warmCabin
improve error handling for custom distributions
b8fb9d3
@warmCabin
fix double update bug in shuffle selection
67e15ff
@warmCabin
Revert "fix double update bug in shuffle selection"
982c8c7 
This reverts commit 67e15ff.
@warmCabin
fix double update bug in shuffle selection, for real
711a5d1 
Didn't realize I was working around generated code here at first!
@warmCabin
put parentheses around the "Advanced" ghost option
4dada9c
@warmCabin
fix the same darn thing in ShuffleDialog
ada0ceb
@warmCabin
return boolean from ArrayManager so we can revert list selection on f…
7218085 
…ailure
@warmCabin
whoops!
e909a31 
Forgot I had been messing around with Reads.java.
@warmCabin
fix precision error in perlin noise distribution
8c68d97 
If the starting offset is too high, 1/arrayLength will be less than the
minimum float delta at that point. When that happens, we get 9001 copies of the
same brown noise output. By using Math.nextUp, we'll get spikier slopes in this
case instead of an empty box.
@warmCabin
fix possibly redundant Math.abs
0a0dd4f 
The idea here is to normalize the minimum to 0. Now it works whether that
minimum is positive or negative.
@warmCabin
docs
252c704 
Please let me know if I'm full of crap on these
@warmCabin
increment aux writes in a couple of places
28c66dd
@warmCabin
don't decrement allocAmount if array wasn't actually removed
9cf8bdd
@warmCabin
fix javadoc
da42b68
@warmCabin
whoops
5588c74
@warmCabin
fix whatever this is
6511f14 
I searched the project for href and found this interesting design decision
@rylid-umil rylid-umil mentioned this pull request Jul 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@warmCabin