Adds language files for QB64 (vanilla and $NOPREFIX mode) #133

FellippeHeitor · 2020-04-19T14:28:21Z

No description provided.

FellippeHeitor · 2020-04-19T14:31:24Z

Oh dang... whitespace at EOL. Hold on.

Third commit is a charm.

BenBE · 2020-04-19T15:04:22Z

Looking through the language file it looks good so far. There are some issues commonly popping up, that are usually easy to fix.

Let's dig in:

1) LangCheckTest::test_langfile with data set "qb64" ('/home/travis/build/GeSHi/gesh...64.php')
The following issues were found in /home/travis/build/GeSHi/geshi-1.0/tests/../src/geshi/qb64.php:
[WARNING] Language file contains an empty keyword list in $language_data['KEYWORDS'] for group 1!
[NOTICE]  Language file contains an keyword ('?') at $language_data['KEYWORDS'][3][23] which seems to be better suited for the symbols section!

The first warning is a note about the first keyword group, which is currently empty. Traditionally this keyword group contains control flow statements and other structural keywords (like SUB, FUNCTION, RETURN). Having that group empty is a waste of resources, as this takes up extra cycles without doing any highlighting work.

The notice below is a hint regarding one of the keywords listed in the second keyword group. GeSHi differentiates between keywords (mostly letters) and operators/symbols (usually no letters) as keywords are matched with additional boundary conditions. The entry ? should thus be moved into its own symbols group (if it really should stay separate).

Which brings up another point I noticed with that first language file: Some keywords begin with $ which is AFAIR totally fine in QBasic and also doesn't cause trouble for GeSHi per se, but you might consider to split those into separate keyword group. Doing so allows to optimize things a bit more (like having a optimized keyword locator regexp set in PARSER_CONTROL -> KEYWORDS -> DISALLOWED_BEFORE/AFTER).

The second language file basically complains about the same first two issues. The other issues reported are keywords that appear more than once in the language file and thus may cause ambiguity when highlighting. Also at times this can cause problems with the URL linking feature if keywords in one (later) group match on URLs generated for keywords in an earlier group.

I hope this helps so far.

FellippeHeitor · 2020-04-19T15:13:55Z

Will work on those.

Adds coloring for $metacommands group.

FellippeHeitor · 2020-04-19T16:18:18Z

Oh, finally 👍

BenBE · 2020-04-19T16:31:49Z

CHANGELOG

@@ -17,6 +17,7 @@ Version 1.0.9.1
     * OpenSSH config (Kevin Ernst)
     * roff (Artur Iwicki)
     * Wolfram (Mysterious Light)
+     * QB64 (changes to Nigel McNie's work on qbasic.php made by Fellippe Heitor/QB64 Team)


Just your name here is fine; list is alphabetical.

Should also start a new block for Version 1.0.9.2 (1.0.9.1 has been released already).

Cool, will change it.

BenBE · 2020-04-19T16:35:55Z

src/geshi/qb64.php

+ * Author: Nigel McNie ([email protected])
+ * Copyright: (c) 2004 Nigel McNie (http://qbnz.com/highlighter/)


Just add your name here in that list. Usually there's no extra mod by line - everybody who considers himself to have contributed enough to feel the need to be mentioned may add himself as (co)author)..

BenBE · 2020-04-19T16:36:59Z

src/geshi/qb64.php

+ * Original file: qbasic.php
+ * Author: Nigel McNie ([email protected])
+ * Copyright: (c) 2004 Nigel McNie (http://qbnz.com/highlighter/)
+ * Release Version: 1.0.9.0


1.0.9.2 (although this will be updated automagically when I prepare updates).

BenBE · 2020-04-19T16:37:28Z

src/geshi/qb64.php

+ * Release Version: 1.0.9.0
+ * Date Started: 2004/06/20
+ *
+ * QBasic/QuickBASIC language file for GeSHi.


QB64 langauge file … I presume?

BenBE · 2020-04-19T16:46:08Z

src/geshi/qb64.php

+ * -------------------------
+ * * Make sure all possible combinations of keywords with
+ *   a space in them (EXIT FOR, END SELECT) are added
+ *   to the first keyword group


Please note that there's a special PARSER_CONTROL (cf. vbscript language or bash:

geshi-1.0/src/geshi/bash.php

Line 471 in fd22ab7

'SPACE_AS_WHITESPACE' => false

) to tell GeSHi to treat any number of whitespace (tab+blanks) as one space. Thus EXIT FOR will still match if there was more than one tab or space to separate those keywords.

I'll check what's been done to the vbscript parser, thanks.

BenBE · 2020-04-19T16:48:35Z

src/geshi/qb64.php

+    'COMMENT_MULTI' => array(),
+    'COMMENT_REGEXP' => array(
+        //Single-Line Comments using REM command
+        2 => "/\bREM.*?$/i",


Note sure here, but does REMOTE at the begin of a line really start a comment too? Or should it be /\bREM\b.*?$/i?

Regex is beyond me, but REM does require at least one space before comment starts. I trust that's what your proposed fix does, so I'll be adding it and testing it to see if it goes as intended. Thanks!

BenBE · 2020-04-19T16:50:40Z

src/geshi/qb64.php

+        GESHI_NUMBER_FLT_NONSCI_F | GESHI_NUMBER_FLT_SCI_SHORT |
+        GESHI_NUMBER_FLT_SCI_ZERO,
+    'KEYWORDS' => array(
+        3 => array(


Not a hard requirement, but keyword groups should be indexed starting at 1. Many generic stylesheets somewhat rely on that to provide reasonable highlighting even for new languages.

NB: Commonly grouping is roughly based on: kw1-> reserved words/control flow, kw2->built-in functions, kw3->common other stuff usually used (like system-provided variables), kw4…->all the other stuff.

Yeah, because of the typical grouping convention I felt I should skip block 1 since for QBasic-based languages it's all keywords really, regardless of being control flow keywords (Nigel skipped block 1 for the original qbasic.php, leaving it blank - which caused issues with the CI and brought considerable confusion to me) but I'll reassign the proper sequential number to those starting at 1.

BenBE · 2020-04-19T16:55:29Z

src/geshi/qb64np.php

+ * qb64np.php
+ * Mod by: Fellippe Heitor ([email protected])
+ * ----------
+ * Original file: qbasic.php
+ * Author: Nigel McNie ([email protected])
+ * Copyright: (c) 2004 Nigel McNie (http://qbnz.com/highlighter/)
+ * Release Version: 1.0.9.0
+ * Date Started: 2004/06/20
+ *
+ * QBasic/QuickBASIC language file for GeSHi.


Cf. notes on the other file.

BTW: What's the diff between qb64 and qb64np?

With v1.4 QB64 introduced a metacommand ($NOPREFIX) that allows both _TITLE and TITLE to be used, reducing typing. File qb64np.php includes both prefixed and non-prefixed keywords, so users can highlight their code properly in the forum:

Is it possible to use $NOPREFIX as a trigger to allow a certain keyword group to be toggled? I thought that might have been too much to ask, hence the pair of language files.

The GeSHi 1.0 branch does not allow for much of contextual highlighting (parser limitation), while the GeSHi 1.1 branch (other repo) even allows for nesting languages and other crazy things. So splitting those two use-cases is fine.

If all keywords of a group should be matched with and without a certain prefix you might even play with the PARSER_CONTROL -> KEYWORDS -> BEFORE setting matching the usual boundary followed by an optional _?. Keywords themselves would be without the underscore in the keyword list only. But that's probably best for some separate PR.

BenBE · 2020-04-19T16:56:57Z

src/geshi/qb64np.php

+        3 => 'http://www.qb64.org/wiki/index.php/{FNAMEU}',
+        4 => 'http://www.qb64.org/wiki/index.php/{FNAMEU}',
+        5 => 'http://www.qb64.org/wiki/index.php/{FNAMEU}'


Please link HTTPS if you provide proper TLS.

BenBE · 2020-04-19T16:57:31Z

src/geshi/qb64.php

+        3 => 'http://www.qb64.org/wiki/index.php/{FNAMEU}',
+        4 => 'http://www.qb64.org/wiki/index.php/{FNAMEU}'


Please link to the HTTPS version as you provide TLS on your site.

BenBE

LGTM. Sorry for the late feedback.

Adds language files for QB64 (vanilla and $NOPREFIX mode)

28cfe6f

FellippeHeitor added 3 commits April 19, 2020 11:35

Maybe fix all trailing whitespace at EOL?

2bc38d7

Fixes "Language file contains no newline at EOF!"

64af2f1

Third commit is a charm.

Updates CHANGELOG

899b0f8

FellippeHeitor added 2 commits April 19, 2020 13:09

Adapts language files to CI constraints. Also:

03aab28

Adds coloring for $metacommands group.

Fixes case sensitiveness block.

8da8f1e

BenBE reviewed Apr 19, 2020

View reviewed changes

FellippeHeitor added 2 commits April 21, 2020 19:18

Final touches.

11fd556

Adds copyright notices.

b2f6230

BenBE approved these changes Sep 7, 2020

View reviewed changes

BenBE force-pushed the master branch from 8ce9435 to 17ff9b2 Compare March 17, 2024 14:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds language files for QB64 (vanilla and $NOPREFIX mode) #133

Adds language files for QB64 (vanilla and $NOPREFIX mode) #133

FellippeHeitor commented Apr 19, 2020

FellippeHeitor commented Apr 19, 2020

BenBE commented Apr 19, 2020

FellippeHeitor commented Apr 19, 2020

FellippeHeitor commented Apr 19, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020 •

edited

Loading

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE Sep 7, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE Apr 19, 2020

FellippeHeitor Apr 19, 2020

BenBE left a comment

		* Author: Nigel McNie ([email protected])
		* Copyright: (c) 2004 Nigel McNie (http://qbnz.com/highlighter/)

		3 => 'http://www.qb64.org/wiki/index.php/{FNAMEU}',
		4 => 'http://www.qb64.org/wiki/index.php/{FNAMEU}'

Adds language files for QB64 (vanilla and $NOPREFIX mode) #133

Are you sure you want to change the base?

Adds language files for QB64 (vanilla and $NOPREFIX mode) #133

Conversation

FellippeHeitor commented Apr 19, 2020

FellippeHeitor commented Apr 19, 2020

BenBE commented Apr 19, 2020

FellippeHeitor commented Apr 19, 2020

FellippeHeitor commented Apr 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FellippeHeitor Apr 19, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BenBE left a comment

Choose a reason for hiding this comment

FellippeHeitor Apr 19, 2020 •

edited

Loading