Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/holo hosting support #165

Merged
merged 12 commits into from
Aug 29, 2023
Merged

Feat/holo hosting support #165

merged 12 commits into from
Aug 29, 2023

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Jul 27, 2023

Fix support for holo hosting, with latest envoy server and @holo-host/web-sdk client.

To test this, you'll need to get a copy of the envoy server, and place it in the root of the directory as holo-dev-server.

@mattyg mattyg changed the base branch from develop to build/upgrade-to-holochain-0.2 July 27, 2023 22:28
@mattyg mattyg requested a review from jost-s July 27, 2023 22:28
Base automatically changed from build/upgrade-to-holochain-0.2 to develop July 31, 2023 20:46
@mattyg mattyg changed the base branch from develop to main August 2, 2023 02:03
@jost-s
Copy link
Collaborator

jost-s commented Aug 9, 2023

Hi @mattyg, maybe you can help me out here. I've compiled the holo dev server for macos and run the command npm run start:holo:agent. The console doesn't show errors anymore after initializing the keystore and rebuilding the happ.
However the web UI isn't able to connect and the browser console shows
image

Do you know why it cannot connect to the resolver?

@mattyg
Copy link
Collaborator Author

mattyg commented Aug 9, 2023

@jost-s Not sure I'm not getting that error - maybe a version mismatch? I'm on chaperone 0.1.0 and you're on 0.1.1. I assume you ran an npm install to get my fork of @holo-host/web-sdk?

Also it looks like I still have to refresh manually before it loads when starting via npm run start:holo:agent -- I think some error in COMB isn't bubbling up or something.

Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! All I had to do was to switch to the 0.6.13-prerelease version of web-sdk from your fork and it was all groovy!

@mattyg
Copy link
Collaborator Author

mattyg commented Aug 11, 2023

Awesome! All I had to do was to switch to the 0.6.13-prerelease version of web-sdk from your fork and it was all groovy!

huh weird. What do you mean by all groovy? For me with the 0.6.13-prerelease version I get an error in console Uncaught (in promise) TypeError: u8a is undefined and after signing into holo I get a white screen because its expecting to have client.myPubKey which the holo version of AppAgentClient is missing.

Maybe I'll ask robbie for the latest envoy build and see if I can reproduce what you're seeing

@jost-s
Copy link
Collaborator

jost-s commented Aug 11, 2023

Oh, okay. Yeah, I meant all groovy because it all worked perfectly after updating the package. I'll send you a recent build for Linux by email.

@mattyg
Copy link
Collaborator Author

mattyg commented Aug 11, 2023

okay great well it works now by using the npm package directly rather than the git branch, except that the iframe stylesheets are empty.

Also I should try to handle the envoy, signup and cells loading to avoid needing to refresh. I'd also like to see if I can avoid the profiles errors thrown when we only have an anonymous agent.

@mattyg
Copy link
Collaborator Author

mattyg commented Aug 29, 2023

Okay I came up with a workaround to avoid the weird inconsistencies between the holo client and holochain client, such that we still only need 1 if statement to differentiate their setup. It resolves the need to refresh the page to complete the holo client setup.

The stylesheet seems to be rendering properly as well for web-sdk version 0.6.13-prerelease

@mattyg mattyg requested a review from jost-s August 29, 2023 20:45
@mattyg mattyg merged commit a1ec6ed into main Aug 29, 2023
1 of 2 checks passed
@mattyg mattyg deleted the feat/holo-hosting-support branch August 29, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants