Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mew content display #171

Merged
merged 8 commits into from
Aug 8, 2023
Merged

Fix/mew content display #171

merged 8 commits into from
Aug 8, 2023

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Aug 3, 2023

  • fix: break long words to fit into mew content div
  • fix: ensure that links are not broken into new lines in webkit
  • feat: change styling of 'show more' button for truncated mew content
  • feat: remove 'show less' button for truncated mew content
  • feat: do not truncate mew content in its yarn view, nor in create mew dialog
  • fix: truncate a single word longer than truncation length at the truncation length - 15 chars
  • fix: break long words in mew quotes to fit into mew embed div

@mattyg mattyg requested a review from jost-s August 3, 2023 21:25
@jost-s
Copy link
Collaborator

jost-s commented Aug 4, 2023

In a mew a long word is displayed fine. I don't know how it was before, now it's contained in the box anyway.

A long word in a quote looks cut off:
image

@jost-s
Copy link
Collaborator

jost-s commented Aug 4, 2023

The mew is completely hidden instead of being truncated. Is that intended?

image

@jost-s
Copy link
Collaborator

jost-s commented Aug 4, 2023

I don't know what the issue in webkit with links was, but it looks fine
image

Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@mattyg mattyg requested a review from jost-s August 7, 2023 01:49
@jost-s
Copy link
Collaborator

jost-s commented Aug 8, 2023

Works fantastically!

After creating a mew with long text, I'm taken to the mewsfeed and that very mew I just created isn't abbreviated. That's intentional, I suppose?!

@mattyg
Copy link
Collaborator Author

mattyg commented Aug 8, 2023

Works fantastically!

After creating a mew with long text, I'm taken to the mewsfeed and that very mew I just created isn't abbreviated. That's intentional, I suppose?!

Yep, the mew is only abbreviated if more than 300 characters

@mattyg mattyg merged commit 7756cfe into main Aug 8, 2023
1 of 2 checks passed
@mattyg mattyg deleted the fix/mew-content-display branch August 8, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants