Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): infinite scroll of followers / creators lists #220

Merged
merged 4 commits into from
Sep 10, 2023
Merged

fix(ui): infinite scroll of followers / creators lists #220

merged 4 commits into from
Sep 10, 2023

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Sep 8, 2023

Resolves #187

@mattyg mattyg requested a review from jost-s September 8, 2023 22:10
jost-s
jost-s approved these changes Sep 9, 2023
View reviewed changes
Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is working. I tried it with 5 followees and page limit set to 2, 3, 4.

@jost-s
Copy link
Collaborator

jost-s commented Sep 9, 2023

One await too many here https://github.com/GeekGene/mewsfeed/pull/220/files#diff-73289534eedce049cb269935139a2a58180c855a003fcc9a60d008b6093767f3L67

@mattyg mattyg merged commit 717db00 into main Sep 10, 2023
1 of 2 checks passed
@mattyg mattyg deleted the fix/followers-creators-list-pagination branch September 10, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After following > 10 agents, the earlier agents do not appear in the followers list
2 participants
@mattyg @jost-s