Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dna): notifications only include responses *after* my response #221

Merged
merged 7 commits into from
Sep 11, 2023
Merged

fix(dna): notifications only include responses *after* my response #221

merged 7 commits into from
Sep 11, 2023

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Sep 8, 2023

Resolves #212

@jost-s
Copy link
Collaborator

jost-s commented Sep 10, 2023

Hmm, something is off. There are two responses to a mew by agent A. Then agent B replies and agent A sees three notifications about replies by B.
image

@mattyg
Copy link
Collaborator Author

mattyg commented Sep 10, 2023

Hmm, something is off. There are two responses to a mew by agent A. Then agent B replies and agent A sees three notifications about replies by B.

great catch -- fixed

@mattyg mattyg requested a review from jost-s September 10, 2023 05:06
jost-s
jost-s requested changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent A gets two notifications after agent B replies once:
image

@mattyg
fix(dna): de-duplicate notifications for both 'reply to my mew' and '…
0a343a3 
…replied to a yarn you participated in' when yarn author also replied to themselves
@mattyg
Copy link
Collaborator Author

mattyg commented Sep 11, 2023

Agent A gets two notifications after agent B replies once

amazing catch - fixed

@mattyg mattyg requested a review from jost-s September 11, 2023 17:00
jost-s
jost-s approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattyg mattyg merged commit d2a24bf into main Sep 11, 2023
1 of 2 checks passed
@mattyg mattyg deleted the fix/notifications-only-show-responses-after-mine branch September 11, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications of responses to mews you also responded to should only include responses *after* your own
2 participants
@mattyg @jost-s