Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): Manage dialogs from stores, remove duplicates #232

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Sep 9, 2023

Reduce unnecessary redundant components by moving dialogs from within BaseMewListItem to MainLayout. Use stores to manage opening dialogs.

Resolves #229
Resolves #226

…use store to trigger opening dialog, remove redundant dialogs from within BaseMewListItem components
Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

works both when replying
image

and when pinning
image

@mattyg mattyg merged commit 199cac1 into main Sep 11, 2023
2 checks passed
@mattyg mattyg deleted the refactor/remove-redundant-dialogs branch September 11, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants